You are viewing a plain text version of this content. The canonical link for it is here.

Posted to gitbox@hive.apache.org by GitBox <gi...@apache.org> on 2022/11/15 01:59:11 UTC

[GitHub] [hive] amansinha100 commented on a diff in pull request #3752: HIVE-26726: Tinyint column with windowing fn crashes at runtime

amansinha100 commented on code in PR #3752:
URL: https://github.com/apache/hive/pull/3752#discussion_r1022239726


##########
ql/src/java/org/apache/hadoop/hive/ql/udf/ptf/ValueBoundaryScanner.java:
##########
@@ -760,6 +760,7 @@ public static SingleValueBoundaryScanner getBoundaryScanner(BoundaryDef start, B
     case "int":
     case "bigint":
     case "smallint":
+    case "tinyint":

Review Comment:
   Good catch.  But can you also check if this type needs to be handled anywhere else for the window function code ? e.g line 730 above.  



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: gitbox-unsubscribe@hive.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: gitbox-unsubscribe@hive.apache.org
For additional commands, e-mail: gitbox-help@hive.apache.org