[GitHub] [apisix-java-plugin-runner] tzssangglass commented on a change in pull request #46: fix: disable logback, use log4j2

[GitBox <gi...@apache.org>]

tzssangglass commented on a change in pull request #46:
URL: https://github.com/apache/apisix-java-plugin-runner/pull/46#discussion_r661072685



##########
File path: runner-core/src/test/java/org/apache/apisix/plugin/runner/handler/A6ConfigHandlerTest.java
##########
@@ -157,12 +153,11 @@ void testAddFilter3(CapturedOutput capturedOutput) {
 
         A6Conf config = cache.getIfPresent(0L);
         Assertions.assertEquals(config.getChain().getFilters().size(), 1);
-        Assertions.assertTrue(capturedOutput.getOut().contains("skip the same filter: FooFilter"));
     }
 
     @Test
     @DisplayName("test receive undefined filter")
-    void testAddFilter4(CapturedOutput capturedOutput) {

Review comment:
       Not entirely possible, as these logs are defined in the source code. and the logging for A6HttpCallHandlerTest.java is defined in the test code. I will try to work it out in another way.




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@apisix.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org