You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@community.apache.org by "bdelacretaz (via GitHub)" <gi...@apache.org> on 2023/11/28 09:08:24 UTC
[PR] Add link to GitHub page source (comdev-site)
bdelacretaz opened a new pull request, #147:
URL: https://github.com/apache/comdev-site/pull/147
(no comment)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@community.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@community.apache.org
For additional commands, e-mail: dev-help@community.apache.org
Re: [PR] Add link to GitHub page source (comdev-site)
Posted by "bdelacretaz (via GitHub)" <gi...@apache.org>.
bdelacretaz commented on PR #147:
URL: https://github.com/apache/comdev-site/pull/147#issuecomment-1829389567
Preview will be available at https://community-edit-github.staged.apache.org/contributors/asf-volunteers.html
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@community.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@community.apache.org
For additional commands, e-mail: dev-help@community.apache.org
Re: [PR] Add link to GitHub page source (comdev-site)
Posted by "bdelacretaz (via GitHub)" <gi...@apache.org>.
bdelacretaz merged PR #147:
URL: https://github.com/apache/comdev-site/pull/147
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@community.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@community.apache.org
For additional commands, e-mail: dev-help@community.apache.org
Re: [PR] Add link to GitHub page source (comdev-site)
Posted by "sebbASF (via GitHub)" <gi...@apache.org>.
sebbASF commented on PR #147:
URL: https://github.com/apache/comdev-site/pull/147#issuecomment-1829591322
I only checked the home page and one other, which was perhaps a section page.
Seems to be OK now
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@community.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@community.apache.org
For additional commands, e-mail: dev-help@community.apache.org
Re: [PR] Add link to GitHub page source (comdev-site)
Posted by "bdelacretaz (via GitHub)" <gi...@apache.org>.
bdelacretaz commented on code in PR #147:
URL: https://github.com/apache/comdev-site/pull/147#discussion_r1407570808
##########
layouts/partials/website-source.html:
##########
@@ -0,0 +1,7 @@
+<p>
+ This website is generated from the <a href="{{ .Site.Params.repositoryUrl }}">comdev-site repository</a>
+ {{ if .IsPage }}
Review Comment:
It works for me on the [preview](https://community-edit-github.staged.apache.org/newcomers/gettingStarted.html), do you see problems? I just pushed a commit to also generate links for section and home pages, that wasn't working before.
IIUC the Page context is passed to the partial as it's included using
{{ partial "website-source.html" .}}
with the dot at the end for context.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@community.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@community.apache.org
For additional commands, e-mail: dev-help@community.apache.org
Re: [PR] Add link to GitHub page source (comdev-site)
Posted by "sebbASF (via GitHub)" <gi...@apache.org>.
sebbASF commented on code in PR #147:
URL: https://github.com/apache/comdev-site/pull/147#discussion_r1407547158
##########
layouts/partials/website-source.html:
##########
@@ -0,0 +1,7 @@
+<p>
+ This website is generated from the <a href="{{ .Site.Params.repositoryUrl }}">comdev-site repository</a>
+ {{ if .IsPage }}
Review Comment:
Looks like IsPage may not work when present in a partial.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@community.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@community.apache.org
For additional commands, e-mail: dev-help@community.apache.org