[GitHub] [hudi] nsivabalan commented on a diff in pull request #7362: [HUDI-5315] The record size is dynamically estimated when the table i…

[GitBox <gi...@apache.org>]

nsivabalan commented on code in PR #7362:
URL: https://github.com/apache/hudi/pull/7362#discussion_r1040232409


##########
hudi-client/hudi-spark-client/src/main/java/org/apache/hudi/table/action/commit/BaseSparkCommitActionExecutor.java:
##########
@@ -419,4 +427,23 @@ public Partitioner getLayoutPartitioner(WorkloadProfile profile, String layoutPa
   protected void runPrecommitValidators(HoodieWriteMetadata<HoodieData<WriteStatus>> writeMetadata) {
     SparkValidatorUtils.runValidators(config, writeMetadata, context, table, instantTime);
   }
+
+  private long dynamicSampleRecordSize(JavaRDD<HoodieRecord<T>> inputRecords) {
+    long dynamicSampleRecordSize = 1024;

Review Comment:
   can we fetch this directly from the Config's default value rather than hard coding it here



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org