You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@maven.apache.org by GitBox <gi...@apache.org> on 2021/10/02 09:04:37 UTC

[GitHub] [maven] cstamas edited a comment on pull request #438: [MNG-7083] - introduce lazy Log message evaluation

cstamas edited a comment on pull request #438:
URL: https://github.com/apache/maven/pull/438#issuecomment-932717398


   I really don't think we want to invent new logging API. Let me explain:
   * I do agree with @rmannibucau et al that "slf4j-api should not leak into plugins", but IMHO none of the reasons listed above is the **real issue**.
   * IMHO, the **real issue** is that slf4j-api is "like Guava", is literally everywhere, and (in short term future) will be _really easy to end up **(in complex plugins, kinda edge case)** with a class-path that contains 1.5, 1.7 and 2.x versions of slf4j-api (and let's assume they will be incompatible)_. 
   * This is true for **complex plugins** that usually drag in components from different dependencies/projects. OTOH, **simple plugins** (dependency wise, not functionality or logic wise) that has only components "rolled by it's own" CAN control which ~~slf4j-api~~ Logging API it expects and uses.
   * Hence, IMHO Maven should not be an impediment (or trouble source) to developers of "complex plugins", by adding a "yet another" slf4j-api version to their (possibly already complex) equation to solve.
   
   Still, as plugin realms are "self first", I think plugin developers are able to solve Mojo (and their component, rolled by own or imported from foreign projects a dependencies) using any logging API they want.
   
   Considering all this above, I'd rather expect to make Mojo Logger "closer" to slf4j-api, not only to simplify our work (to adapt slf4j logger to Mojo Logger), but also as sl4j logger _is lazy as well_, without any extra code. As in case of Mojo Logger, our wrapper will protect users of Mojo logger from sl4j-api incompatibilities (is provided at runtime by Maven Core).


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@maven.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org