You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@spark.apache.org by "ericm-db (via GitHub)" <gi...@apache.org> on 2023/07/17 01:04:27 UTC

[GitHub] [spark] ericm-db commented on a diff in pull request #42012: [SPARK-44440][SS] Use thread pool to perform maintenance activity for hdfs/rocksdb state store providers

ericm-db commented on code in PR #42012:
URL: https://github.com/apache/spark/pull/42012#discussion_r1264777289


##########
sql/core/src/main/scala/org/apache/spark/sql/execution/streaming/state/StateStore.scala:
##########
@@ -439,6 +439,14 @@ object StateStore extends Logging {
   @GuardedBy("loadedProviders")
   private val schemaValidated = new mutable.HashMap[StateStoreProviderId, Option[Throwable]]()
 
+  private val threadPoolLock = new Object

Review Comment:
   Sure. I think this refactor might be out of the scope of this PR, but this makes sense to me.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org