[jira] [Commented] (PLC4X-159) modbus: Future which writes data correctly in modbus does not return

["Christofer Dutz (Jira)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/PLC4X-159?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16988819#comment-16988819 ] 

Christofer Dutz commented on PLC4X-159:
---------------------------------------

Would it be possilbe to do a wireshark dump of the communication when doing this write operation?.

It could be that we are expecting a response and the device isn't doing that ... I would like to make sure how to address this issue ASAP

> modbus: Future which writes data correctly in modbus does not return
> --------------------------------------------------------------------
>
>                 Key: PLC4X-159
>                 URL: https://issues.apache.org/jira/browse/PLC4X-159
>             Project: Apache PLC4X
>          Issue Type: Bug
>          Components: Driver-Modbus
>            Reporter: Alvaro del Castillo
>            Priority: Major
>
> When writing data registers in modbus, the data is written correctly but the Future which does it does not return. The hack is just to not wait for the Future because you don't need the results. Just that the data is written. But if there are some error during the writing you don't know it. And probably the resources are not freed correctly.
> Some sample code:
> {code:java}
> PlcWriteRequest writeRequest =  connection.writeRequestBuilder()
>   .addItem(registerName, "register:" + offset + "[" + size + "]", writeRegister)
>   .build();
> writeRequest.execute().whenComplete((writeResponse, error) -> {
>   assertNotNull(writeResponse);
> });
> {code}
> The whenComplete is never called. I have follow the code and the "decode" method is called, so it is when processing the response from the modbus slave where the problem is.



--
This message was sent by Atlassian Jira
(v8.3.4#803005)