You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@tomee.apache.org by GitBox <gi...@apache.org> on 2022/05/10 21:05:05 UTC
[GitHub] [tomee] tichovz opened a new pull request, #883: Tomee 3824
tichovz opened a new pull request, #883:
URL: https://github.com/apache/tomee/pull/883
I create a new method into ObjectFactory and a new test method, where unmarshalling the web-fragment.xml is successful.
Sorry I made a code format in JeeTest.java.
Unfortunately I do not know how to test ObjectFactory.createWebFragment method.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@tomee.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
AW: [GitHub] [tomee] rzo1 commented on a diff in pull request #883: Tomee 3824
Posted by "Zowalla, Richard" <ri...@hs-heilbronn.de>.
Hi,
it's about the same Jira Issue, so it's fine to use this pull request.
Many thanks for your contribution!
Gruß
Richard
________________________________
Von: Zoltán Tichov <zo...@gmail.com>
Gesendet: Samstag, 14. Mai 2022 21:16:03
An: dev@tomee.apache.org
Betreff: Re: [GitHub] [tomee] rzo1 commented on a diff in pull request #883: Tomee 3824
Hi!
I resolve the issue, do I need to make a new pull request?
Thanks: Zoltán
On Sat, May 14, 2022 at 7:31 PM GitBox <gi...@apache.org> wrote:
>
> rzo1 commented on code in PR #883:
> URL: https://github.com/apache/tomee/pull/883#discussion_r873055259
>
>
> ##########
>
> container/openejb-jee/src/main/java/org/apache/openejb/jee/ObjectFactory.java:
> ##########
> @@ -166,4 +167,12 @@ public JAXBElement<Webservices> createConnector(final
> Webservices value) {
> public JAXBElement<FacesConfig> createFacesConfig(final FacesConfig
> value) {
> return new JAXBElement<FacesConfig>(_FacesConfig_QNAME,
> FacesConfig.class, null, value);
> }
> +
> + /**
> + * Create an instance of {@link JAXBElement }{@code <}{@link
> WebFragment }{@code >}}
> + */
> + @XmlElementDecl(namespace = "http://java.sun.com/xml/ns/javaee",
> name = "web-fragment")
>
> Review Comment:
> Thanks for the comment. I think, that the best way would be to follow
> up on the list. @dblevins might have some thoughts / insights here.
>
> Often the best way to get answers / details is to ask on the list. The
> cool thing is, that the list archive will have this information years later.
>
>
>
> --
> This is an automated message from the Apache Git Service.
> To respond to the message, please log on to GitHub and use the
> URL above to go to the specific comment.
>
> To unsubscribe, e-mail: dev-unsubscribe@tomee.apache.org
>
> For queries about this service, please contact Infrastructure at:
> users@infra.apache.org
>
>
Re: [GitHub] [tomee] rzo1 commented on a diff in pull request #883: Tomee 3824
Posted by Zoltán Tichov <zo...@gmail.com>.
Hi!
I resolve the issue, do I need to make a new pull request?
Thanks: Zoltán
On Sat, May 14, 2022 at 7:31 PM GitBox <gi...@apache.org> wrote:
>
> rzo1 commented on code in PR #883:
> URL: https://github.com/apache/tomee/pull/883#discussion_r873055259
>
>
> ##########
>
> container/openejb-jee/src/main/java/org/apache/openejb/jee/ObjectFactory.java:
> ##########
> @@ -166,4 +167,12 @@ public JAXBElement<Webservices> createConnector(final
> Webservices value) {
> public JAXBElement<FacesConfig> createFacesConfig(final FacesConfig
> value) {
> return new JAXBElement<FacesConfig>(_FacesConfig_QNAME,
> FacesConfig.class, null, value);
> }
> +
> + /**
> + * Create an instance of {@link JAXBElement }{@code <}{@link
> WebFragment }{@code >}}
> + */
> + @XmlElementDecl(namespace = "http://java.sun.com/xml/ns/javaee",
> name = "web-fragment")
>
> Review Comment:
> Thanks for the comment. I think, that the best way would be to follow
> up on the list. @dblevins might have some thoughts / insights here.
>
> Often the best way to get answers / details is to ask on the list. The
> cool thing is, that the list archive will have this information years later.
>
>
>
> --
> This is an automated message from the Apache Git Service.
> To respond to the message, please log on to GitHub and use the
> URL above to go to the specific comment.
>
> To unsubscribe, e-mail: dev-unsubscribe@tomee.apache.org
>
> For queries about this service, please contact Infrastructure at:
> users@infra.apache.org
>
>
[GitHub] [tomee] cesarhernandezgt commented on pull request #883: Tomee 3824
Posted by GitBox <gi...@apache.org>.
cesarhernandezgt commented on PR #883:
URL: https://github.com/apache/tomee/pull/883#issuecomment-1122907477
Hi @tichovz , thank you for the PR.
The PR is against apache:develop (last updated back in 2015); perhaps you may want to open this against the current Master branch?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@tomee.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [tomee] rzo1 commented on a diff in pull request #883: Tomee 3824
Posted by GitBox <gi...@apache.org>.
rzo1 commented on code in PR #883:
URL: https://github.com/apache/tomee/pull/883#discussion_r872020377
##########
container/openejb-jee/src/test/java/org/apache/openejb/jee/JeeTest.java:
##########
@@ -18,23 +18,22 @@
package org.apache.openejb.jee;
+import jakarta.xml.bind.*;
Review Comment:
Can we restore the original import order? It is basically a style change
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@tomee.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [tomee] rzo1 commented on pull request #883: Tomee 3824
Posted by GitBox <gi...@apache.org>.
rzo1 commented on PR #883:
URL: https://github.com/apache/tomee/pull/883#issuecomment-1132487508
@tichovz Thanks!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@tomee.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [tomee] rzo1 commented on a diff in pull request #883: Tomee 3824
Posted by GitBox <gi...@apache.org>.
rzo1 commented on code in PR #883:
URL: https://github.com/apache/tomee/pull/883#discussion_r873055259
##########
container/openejb-jee/src/main/java/org/apache/openejb/jee/ObjectFactory.java:
##########
@@ -166,4 +167,12 @@ public JAXBElement<Webservices> createConnector(final Webservices value) {
public JAXBElement<FacesConfig> createFacesConfig(final FacesConfig value) {
return new JAXBElement<FacesConfig>(_FacesConfig_QNAME, FacesConfig.class, null, value);
}
+
+ /**
+ * Create an instance of {@link JAXBElement }{@code <}{@link WebFragment }{@code >}}
+ */
+ @XmlElementDecl(namespace = "http://java.sun.com/xml/ns/javaee", name = "web-fragment")
Review Comment:
Thanks for the comment. I think, that the best way would be to follow up on the list. @dblevins might have some thoughts / insights here.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@tomee.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [tomee] tichovz commented on a diff in pull request #883: Tomee 3824
Posted by GitBox <gi...@apache.org>.
tichovz commented on code in PR #883:
URL: https://github.com/apache/tomee/pull/883#discussion_r873052745
##########
container/openejb-jee/src/test/resources/web-fragment-example.xml:
##########
@@ -0,0 +1,14 @@
+<?xml version="1.0" encoding="UTF-8"?>
Review Comment:
I pasted the license header, but I have not commited yet.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@tomee.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [tomee] rzo1 commented on pull request #883: Tomee 3824
Posted by GitBox <gi...@apache.org>.
rzo1 commented on PR #883:
URL: https://github.com/apache/tomee/pull/883#issuecomment-1125684017
Thanks for the PR @tichovz - I left some comments.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@tomee.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [tomee] rzo1 commented on a diff in pull request #883: Tomee 3824
Posted by GitBox <gi...@apache.org>.
rzo1 commented on code in PR #883:
URL: https://github.com/apache/tomee/pull/883#discussion_r873055259
##########
container/openejb-jee/src/main/java/org/apache/openejb/jee/ObjectFactory.java:
##########
@@ -166,4 +167,12 @@ public JAXBElement<Webservices> createConnector(final Webservices value) {
public JAXBElement<FacesConfig> createFacesConfig(final FacesConfig value) {
return new JAXBElement<FacesConfig>(_FacesConfig_QNAME, FacesConfig.class, null, value);
}
+
+ /**
+ * Create an instance of {@link JAXBElement }{@code <}{@link WebFragment }{@code >}}
+ */
+ @XmlElementDecl(namespace = "http://java.sun.com/xml/ns/javaee", name = "web-fragment")
Review Comment:
Thanks for the comment. I think, that the best way would be to follow up on the list. @dblevins might have some thoughts / insights here.
Often the best way to get answers / details is to ask on the list. The cool thing is, that the list archive will have this information years later.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@tomee.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [tomee] tichovz commented on pull request #883: Tomee 3824
Posted by GitBox <gi...@apache.org>.
tichovz commented on PR #883:
URL: https://github.com/apache/tomee/pull/883#issuecomment-1131571236
Hi!
Can I do something to make the pull request successful?
Best :
Zoltán
On Mon, May 16, 2022 at 9:24 PM Richard Zowalla ***@***.***>
wrote:
> ***@***.**** approved this pull request.
>
> —
> Reply to this email directly, view it on GitHub
> <https://github.com/apache/tomee/pull/883#pullrequestreview-974461347>,
> or unsubscribe
> <https://github.com/notifications/unsubscribe-auth/AZB6M6PFC55F3C56QXPVXPDVKKOGPANCNFSM5VS2YASQ>
> .
> You are receiving this because you were mentioned.Message ID:
> ***@***.***>
>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@tomee.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [tomee] tichovz commented on a diff in pull request #883: Tomee 3824
Posted by GitBox <gi...@apache.org>.
tichovz commented on code in PR #883:
URL: https://github.com/apache/tomee/pull/883#discussion_r873054636
##########
container/openejb-jee/src/main/java/org/apache/openejb/jee/ObjectFactory.java:
##########
@@ -166,4 +167,12 @@ public JAXBElement<Webservices> createConnector(final Webservices value) {
public JAXBElement<FacesConfig> createFacesConfig(final FacesConfig value) {
return new JAXBElement<FacesConfig>(_FacesConfig_QNAME, FacesConfig.class, null, value);
}
+
+ /**
+ * Create an instance of {@link JAXBElement }{@code <}{@link WebFragment }{@code >}}
+ */
+ @XmlElementDecl(namespace = "http://java.sun.com/xml/ns/javaee", name = "web-fragment")
Review Comment:
I added the web-fragment part to ObjectFactory$JAXB, but I did not solve the issue, because the org.apache.openejb.config.ReadDescriptors.mergeWebFragments calls JaxbJavaee.unmarshall which uses the NoSourceFilter.
It does not translate the namespace "https://jakarta.ee/xml/ns/jakartaee" to "http://java.sun.com/xml/ns/javaee".
So what would I have to do?
1. change ReadDescriptors.mergeWebFragments to call JaxbJavaee.unmarshallJavaee which changes the namespace
2. change the NoSourceFilter to change the jakarta namespace as well not only the "http://xmlns.jcp.org/xml/ns/javaee"
3. anything else
I think I might remove the web-fragment part from ObjectFactory$JAXB
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@tomee.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [tomee] tichovz commented on a diff in pull request #883: Tomee 3824
Posted by GitBox <gi...@apache.org>.
tichovz commented on code in PR #883:
URL: https://github.com/apache/tomee/pull/883#discussion_r873052671
##########
container/openejb-jee/src/test/java/org/apache/openejb/jee/JeeTest.java:
##########
@@ -18,23 +18,22 @@
package org.apache.openejb.jee;
+import jakarta.xml.bind.*;
Review Comment:
I restored the original order, but I have not commited yet.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@tomee.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [tomee] rzo1 merged pull request #883: Tomee 3824
Posted by GitBox <gi...@apache.org>.
rzo1 merged PR #883:
URL: https://github.com/apache/tomee/pull/883
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@tomee.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [tomee] tichovz commented on pull request #883: Tomee 3824
Posted by GitBox <gi...@apache.org>.
tichovz commented on PR #883:
URL: https://github.com/apache/tomee/pull/883#issuecomment-1123271053
Hi!
I changed the target
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@tomee.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [tomee] rzo1 commented on pull request #883: Tomee 3824
Posted by GitBox <gi...@apache.org>.
rzo1 commented on PR #883:
URL: https://github.com/apache/tomee/pull/883#issuecomment-1123234218
I think you are right @cesarhernandezgt if I am following the discussion on the list correctly. @tichovz Would you mind chaning the target to `master` `
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@tomee.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [tomee] rzo1 commented on a diff in pull request #883: Tomee 3824
Posted by GitBox <gi...@apache.org>.
rzo1 commented on code in PR #883:
URL: https://github.com/apache/tomee/pull/883#discussion_r872021449
##########
container/openejb-jee/src/test/resources/web-fragment-example.xml:
##########
@@ -0,0 +1,14 @@
+<?xml version="1.0" encoding="UTF-8"?>
Review Comment:
This file misses a license header - subsequently, the license header checks in CI will fail.
You can ake a look at the other descriptor files and just copy & paste the ASF license header into this file.
##########
container/openejb-jee/src/main/java/org/apache/openejb/jee/ObjectFactory.java:
##########
@@ -166,4 +167,12 @@ public JAXBElement<Webservices> createConnector(final Webservices value) {
public JAXBElement<FacesConfig> createFacesConfig(final FacesConfig value) {
return new JAXBElement<FacesConfig>(_FacesConfig_QNAME, FacesConfig.class, null, value);
}
+
+ /**
+ * Create an instance of {@link JAXBElement }{@code <}{@link WebFragment }{@code >}}
+ */
+ @XmlElementDecl(namespace = "http://java.sun.com/xml/ns/javaee", name = "web-fragment")
Review Comment:
We might need to add `web-fragment` part to `ObjectFactory$JAXB` in `openejb-jee-accessors` to fully support it?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@tomee.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org