[GitHub] [calcite] soma-mondal commented on a change in pull request #1437: [CALCITE-3318] Preserving CAST of STRING operands in comparison operator

[GitBox <gi...@apache.org>]

soma-mondal commented on a change in pull request #1437: [CALCITE-3318] Preserving CAST of STRING operands in comparison operator
URL: https://github.com/apache/calcite/pull/1437#discussion_r335313976
 
 

 ##########
 File path: core/src/main/java/org/apache/calcite/rel/rel2sql/SqlImplementor.java
 ##########
 @@ -193,7 +193,7 @@ public Result setOpToSql(SqlSetOperator operator, RelNode rel) {
    * @param leftFieldCount  Number of fields on left result
    * @return SqlNode that represents the condition
    */
-  public static SqlNode convertConditionToSqlNode(RexNode node,
+  public SqlNode convertConditionToSqlNode(RexNode node,
 
 Review comment:
   Sorry for the late reply. I have added dialect parameter in stripCastFromString method. As this method was static I could not use instance variable dialect to call stripCastFromString.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services