[GitHub] gatorsmile commented on a change in pull request #22149: [SPARK-25158][SQL]Executor accidentally exit because ScriptTransformationWriterThread throw Exception.

[GitBox <gi...@apache.org>]

gatorsmile commented on a change in pull request #22149: [SPARK-25158][SQL]Executor accidentally exit because ScriptTransformationWriterThread throw Exception.
URL: https://github.com/apache/spark/pull/22149#discussion_r253608937
 
 

 ##########
 File path: sql/hive/src/main/scala/org/apache/spark/sql/hive/execution/ScriptTransformationExec.scala
 ##########
 @@ -308,12 +308,15 @@ private class ScriptTransformationWriterThread(
       }
       threwException = false
     } catch {
+      // SPARK-25158 Exception should not be thrown again, otherwise it will be captured by
 
 Review comment:
   All exceptions? How about the fatal exceptions? Should we do it only when it is NonFatal?

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org