You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@druid.apache.org by fj...@apache.org on 2019/05/25 17:12:24 UTC
[incubator-druid] branch master updated: Fix dead code in
IndexTask.collectIntervalsAndShardSpecs() (#7746)
This is an automated email from the ASF dual-hosted git repository.
fjy pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/incubator-druid.git
The following commit(s) were added to refs/heads/master by this push:
new c97eb93 Fix dead code in IndexTask.collectIntervalsAndShardSpecs() (#7746)
c97eb93 is described below
commit c97eb93e16d914e3ad54138efe9d3a3990e1a52a
Author: Jonathan Wei <jo...@users.noreply.github.com>
AuthorDate: Sat May 25 10:12:15 2019 -0700
Fix dead code in IndexTask.collectIntervalsAndShardSpecs() (#7746)
---
.../java/org/apache/druid/indexing/common/task/IndexTask.java | 11 +++++------
1 file changed, 5 insertions(+), 6 deletions(-)
diff --git a/indexing-service/src/main/java/org/apache/druid/indexing/common/task/IndexTask.java b/indexing-service/src/main/java/org/apache/druid/indexing/common/task/IndexTask.java
index 5161f9b..20cee24 100644
--- a/indexing-service/src/main/java/org/apache/druid/indexing/common/task/IndexTask.java
+++ b/indexing-service/src/main/java/org/apache/druid/indexing/common/task/IndexTask.java
@@ -731,8 +731,6 @@ public class IndexTask extends AbstractTask implements ChatHandler
final Map<Interval, Optional<HyperLogLogCollector>> hllCollectors = new TreeMap<>(
Comparators.intervalsByStartThenEnd()
);
- int thrownAway = 0;
- int unparseable = 0;
final Granularity queryGranularity = granularitySpec.getQueryGranularity();
try (
@@ -807,12 +805,13 @@ public class IndexTask extends AbstractTask implements ChatHandler
}
// These metrics are reported in generateAndPublishSegments()
- if (thrownAway > 0) {
- log.warn("Unable to find a matching interval for [%,d] events", thrownAway);
+ if (determinePartitionsMeters.getThrownAway() > 0) {
+ log.warn("Unable to find a matching interval for [%,d] events", determinePartitionsMeters.getThrownAway());
}
- if (unparseable > 0) {
- log.warn("Unable to parse [%,d] events", unparseable);
+ if (determinePartitionsMeters.getUnparseable() > 0) {
+ log.warn("Unable to parse [%,d] events", determinePartitionsMeters.getUnparseable());
}
+
return hllCollectors;
}
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@druid.apache.org
For additional commands, e-mail: commits-help@druid.apache.org