You are viewing a plain text version of this content. The canonical link for it is here.

Posted to commits@activemq.apache.org by de...@apache.org on 2010/11/24 17:03:22 UTC

svn commit: r1038658 - /activemq/trunk/activemq-core/src/main/java/org/apache/activemq/security/SimpleAuthenticationBroker.java

Author: dejanb
Date: Wed Nov 24 16:03:22 2010
New Revision: 1038658

URL: http://svn.apache.org/viewvc?rev=1038658&view=rev
Log:
https://issues.apache.org/activemq/browse/AMQ-3052 - memory leak in SimpleAuthenticationBroker

Modified:
    activemq/trunk/activemq-core/src/main/java/org/apache/activemq/security/SimpleAuthenticationBroker.java

Modified: activemq/trunk/activemq-core/src/main/java/org/apache/activemq/security/SimpleAuthenticationBroker.java
URL: http://svn.apache.org/viewvc/activemq/trunk/activemq-core/src/main/java/org/apache/activemq/security/SimpleAuthenticationBroker.java?rev=1038658&r1=1038657&r2=1038658&view=diff
==============================================================================
--- activemq/trunk/activemq-core/src/main/java/org/apache/activemq/security/SimpleAuthenticationBroker.java (original)
+++ activemq/trunk/activemq-core/src/main/java/org/apache/activemq/security/SimpleAuthenticationBroker.java Wed Nov 24 16:03:22 2010
@@ -92,7 +92,13 @@ public class SimpleAuthenticationBroker 
             context.setSecurityContext(s);
             securityContexts.add(s);
         }
-        super.addConnection(context, info);
+        try {
+            super.addConnection(context, info);
+        } catch (Exception e) {
+            securityContexts.remove(s);
+            context.setSecurityContext(null);
+            throw e;
+        }
     }
 
     public void removeConnection(ConnectionContext context, ConnectionInfo info, Throwable error)