You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@geode.apache.org by Udo Kohlmeyer <uk...@gmail.com> on 2016/03/09 10:17:02 UTC

Review Request 44562: GEODE-1053: Adding "filter" on Function Rest API.

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/44562/
-----------------------------------------------------------

Review request for geode, Bruce Schuchardt, Hitesh Khamesra, Jianxia Chen, and Jens Deppe.


Repository: geode


Description
-------

GEODE-1053: Adding "filter" on Function Rest Invocation. 
Refactoring of RestAPIOnRegionFunctionExecutionDUnitTest.java RestAPIsOnGroupsFunctionExecutionDUnitTest.java RestAPIsOnMembersFunctionExecutionDUnitTest.java. 
Updating dependency-versions.properties for http-core and http-client classpath conflicts.


Diffs
-----

  geode-assembly/src/test/java/com/gemstone/gemfire/rest/internal/web/RestFunctionTemplate.java PRE-CREATION 
  geode-assembly/src/test/java/com/gemstone/gemfire/rest/internal/web/controllers/RestAPIOnRegionFunctionExecutionDUnitTest.java 4a958cef75e1a46069090b724ee1c1d0a135e7a4 
  geode-assembly/src/test/java/com/gemstone/gemfire/rest/internal/web/controllers/RestAPITestBase.java 370947588c5dedd540a50e238215cb224ed99622 
  geode-assembly/src/test/java/com/gemstone/gemfire/rest/internal/web/controllers/RestAPIsOnGroupsFunctionExecutionDUnitTest.java 1ae3810465f87dd7e9f48e7791a18528e9e82de6 
  geode-assembly/src/test/java/com/gemstone/gemfire/rest/internal/web/controllers/RestAPIsOnMembersFunctionExecutionDUnitTest.java adb2b5593e7f0922c886db9f3e3351fb40ec6c87 
  geode-web-api/src/main/java/com/gemstone/gemfire/rest/internal/web/controllers/FunctionAccessController.java 2c37c7f0e73f4354f9b440eaeca7c49ef48ee92a 
  geode-web-api/src/main/java/com/gemstone/gemfire/rest/internal/web/util/ArrayUtils.java 261f9ad09f564e95f83123b22c715cc0ee3b962b 
  gradle/dependency-versions.properties 8a533f61bba808a4f89419888e4f4f9c1803c962 

Diff: https://reviews.apache.org/r/44562/diff/


Testing
-------


Thanks,

Udo Kohlmeyer


Re: Review Request 44562: GEODE-1053: Adding "filter" on Function Rest API.

Posted by Hitesh Khamesra <hk...@pivotal.io>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/44562/#review123705
-----------------------------------------------------------


Ship it!




Ship It!

- Hitesh Khamesra


On March 9, 2016, 6:38 p.m., Udo Kohlmeyer wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/44562/
> -----------------------------------------------------------
> 
> (Updated March 9, 2016, 6:38 p.m.)
> 
> 
> Review request for geode, Bruce Schuchardt, Hitesh Khamesra, Jianxia Chen, and Jens Deppe.
> 
> 
> Repository: geode
> 
> 
> Description
> -------
> 
> GEODE-1053: Adding "filter" on Function Rest Invocation. 
> Refactoring of RestAPIOnRegionFunctionExecutionDUnitTest.java RestAPIsOnGroupsFunctionExecutionDUnitTest.java RestAPIsOnMembersFunctionExecutionDUnitTest.java. 
> Updating dependency-versions.properties for http-core and http-client classpath conflicts.
> 
> 
> Diffs
> -----
> 
>   geode-assembly/src/test/java/com/gemstone/gemfire/rest/internal/web/RestFunctionTemplate.java PRE-CREATION 
>   geode-assembly/src/test/java/com/gemstone/gemfire/rest/internal/web/controllers/RestAPIOnRegionFunctionExecutionDUnitTest.java 4a958cef75e1a46069090b724ee1c1d0a135e7a4 
>   geode-assembly/src/test/java/com/gemstone/gemfire/rest/internal/web/controllers/RestAPITestBase.java 370947588c5dedd540a50e238215cb224ed99622 
>   geode-assembly/src/test/java/com/gemstone/gemfire/rest/internal/web/controllers/RestAPIsOnGroupsFunctionExecutionDUnitTest.java 1ae3810465f87dd7e9f48e7791a18528e9e82de6 
>   geode-assembly/src/test/java/com/gemstone/gemfire/rest/internal/web/controllers/RestAPIsOnMembersFunctionExecutionDUnitTest.java adb2b5593e7f0922c886db9f3e3351fb40ec6c87 
>   geode-web-api/src/main/java/com/gemstone/gemfire/rest/internal/web/controllers/FunctionAccessController.java 2c37c7f0e73f4354f9b440eaeca7c49ef48ee92a 
>   geode-web-api/src/main/java/com/gemstone/gemfire/rest/internal/web/util/ArrayUtils.java 261f9ad09f564e95f83123b22c715cc0ee3b962b 
>   gradle/dependency-versions.properties 8a533f61bba808a4f89419888e4f4f9c1803c962 
> 
> Diff: https://reviews.apache.org/r/44562/diff/
> 
> 
> Testing
> -------
> 
> distributedTest
> 
> 
> Thanks,
> 
> Udo Kohlmeyer
> 
>


Re: Review Request 44562: GEODE-1053: Adding "filter" on Function Rest API.

Posted by Udo Kohlmeyer <uk...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/44562/
-----------------------------------------------------------

(Updated March 9, 2016, 6:38 p.m.)


Review request for geode, Bruce Schuchardt, Hitesh Khamesra, Jianxia Chen, and Jens Deppe.


Repository: geode


Description
-------

GEODE-1053: Adding "filter" on Function Rest Invocation. 
Refactoring of RestAPIOnRegionFunctionExecutionDUnitTest.java RestAPIsOnGroupsFunctionExecutionDUnitTest.java RestAPIsOnMembersFunctionExecutionDUnitTest.java. 
Updating dependency-versions.properties for http-core and http-client classpath conflicts.


Diffs
-----

  geode-assembly/src/test/java/com/gemstone/gemfire/rest/internal/web/RestFunctionTemplate.java PRE-CREATION 
  geode-assembly/src/test/java/com/gemstone/gemfire/rest/internal/web/controllers/RestAPIOnRegionFunctionExecutionDUnitTest.java 4a958cef75e1a46069090b724ee1c1d0a135e7a4 
  geode-assembly/src/test/java/com/gemstone/gemfire/rest/internal/web/controllers/RestAPITestBase.java 370947588c5dedd540a50e238215cb224ed99622 
  geode-assembly/src/test/java/com/gemstone/gemfire/rest/internal/web/controllers/RestAPIsOnGroupsFunctionExecutionDUnitTest.java 1ae3810465f87dd7e9f48e7791a18528e9e82de6 
  geode-assembly/src/test/java/com/gemstone/gemfire/rest/internal/web/controllers/RestAPIsOnMembersFunctionExecutionDUnitTest.java adb2b5593e7f0922c886db9f3e3351fb40ec6c87 
  geode-web-api/src/main/java/com/gemstone/gemfire/rest/internal/web/controllers/FunctionAccessController.java 2c37c7f0e73f4354f9b440eaeca7c49ef48ee92a 
  geode-web-api/src/main/java/com/gemstone/gemfire/rest/internal/web/util/ArrayUtils.java 261f9ad09f564e95f83123b22c715cc0ee3b962b 
  gradle/dependency-versions.properties 8a533f61bba808a4f89419888e4f4f9c1803c962 

Diff: https://reviews.apache.org/r/44562/diff/


Testing (updated)
-------

distributedTest


Thanks,

Udo Kohlmeyer