You are viewing a plain text version of this content. The canonical link for it is here.
Posted to github@arrow.apache.org by "js8544 (via GitHub)" <gi...@apache.org> on 2023/08/09 12:47:07 UTC

[GitHub] [arrow] js8544 commented on pull request #36906: GH-36905: [C++] Add support for SparseUnion to selection functions

js8544 commented on PR #36906:
URL: https://github.com/apache/arrow/pull/36906#issuecomment-1671262057

   
   > It seems that it reuses the DenseUnion approach, but it would be more efficient to reuse the Struct approach. What do you think?
   
   Right, I've changed it to the struct approach. But there is room for improvement for SparseUnion: the unselect children can have any value, so we don't have to call take with the same indices for every child. I've left a TODO comment in the code for this.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org