You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@iceberg.apache.org by GitBox <gi...@apache.org> on 2022/02/22 16:09:09 UTC
[GitHub] [iceberg] XN137 opened a new pull request #4195: Docs: fix numeration in Metastore Tables section
XN137 opened a new pull request #4195:
URL: https://github.com/apache/iceberg/pull/4195
i noticed that the numeration in that section started with the wrong number, which is extra confusing because we refer back to "step 1" further down.
also as a first time reader seeing `<uuid>` when the previous section used `<random-uuid>` made me wonder if there is an important difference.
but looking at the code, it doesnt seem to be the case:
```
~/code/iceberg$ ag "UUID\." core/src/main/java/org/apache/iceberg/hadoop/HadoopTableOperations.java
150: Path tempMetadataFile = metadataPath(UUID.randomUUID().toString() + fileExtension);
289: Path tempVersionHintFile = metadataPath(UUID.randomUUID().toString() + "-version-hint.temp");
427: Preconditions.checkState(newUUID.equals(currentMetadata.uuid()),
~/code/iceberg$ ag "UUID\." core/src/main/java/org/apache/iceberg/BaseMetastoreTableOperations.java
154: // always unique because it includes a UUID.
189: Preconditions.checkState(newUUID.equals(currentMetadata.uuid()),
325: return metadataFileLocation(meta, String.format("%05d-%s%s", newVersion, UUID.randomUUID(), fileExtension));
```
so i suggest to use the latter in this section as well (or we can remove the `random-` prefix in the previous section).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org
[GitHub] [iceberg] rdblue commented on pull request #4195: Docs: fix numeration in Metastore Tables section
Posted by GitBox <gi...@apache.org>.
rdblue commented on pull request #4195:
URL: https://github.com/apache/iceberg/pull/4195#issuecomment-1048339542
Thanks, @XN137! Looks great.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org
[GitHub] [iceberg] rdblue merged pull request #4195: Docs: fix numeration in Metastore Tables section
Posted by GitBox <gi...@apache.org>.
rdblue merged pull request #4195:
URL: https://github.com/apache/iceberg/pull/4195
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org