[GitHub] [flink] zentol commented on a diff in pull request #21492: [FLINK-30378][docs] Add v2 sql_connector_download_table shortcode

[GitBox <gi...@apache.org>]

zentol commented on code in PR #21492:
URL: https://github.com/apache/flink/pull/21492#discussion_r1045758661


##########
docs/layouts/shortcodes/sql_connector_download_table_v2.html:
##########
@@ -0,0 +1,65 @@
+{{/*
+  Licensed to the Apache Software Foundation (ASF) under one
+  or more contributor license agreements.  See the NOTICE file
+  distributed with this work for additional information
+  regarding copyright ownership.  The ASF licenses this file
+  to you under the Apache License, Version 2.0 (the
+  "License"); you may not use this file except in compliance
+  with the License.  You may obtain a copy of the License at
+  
+    http://www.apache.org/licenses/LICENSE-2.0
+  
+  Unless required by applicable law or agreed to in writing,
+  software distributed under the License is distributed on an
+  "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+  KIND, either express or implied.  See the License for the
+  specific language governing permissions and limitations
+  under the License.
+  */}}
+  {{/* 
+    Generates an XML snippet for the SQL connector download table. 
+    IMPORTANT: the whitespace is relevant. Do not change without looking at the 
+    rendered documentation. 
+  */}}
+  {{ $name := .Get 0 }}
+  {{ $connector_version := .Get 1 }}
+  {{ $connector := index .Site.Data $name }}
+  {{ $flink_version := .Site.Params.VersionTitle }}
+  {{ $full_version := printf "%s-%s" $connector_version $flink_version }}
+  
+  {{ $path := .Page.Path }}
+  
+  {{ $hash := md5 now }}
+  
+  {{ if $.Site.Params.IsStable }}
+  <table style="display:table;margin-left:auto;margin-right:auto" id="download-table">
+    <thead>
+      <th style="text-align:left">Maven dependency</th>
+      <th style="text-align:left">SQL Client</th>
+    </thead>
+    <tbody>
+      {{ range $connector.variants }}

Review Comment:
   This was renamed to `variants` because we have enough "versions" flying around in this file.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org