You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@maven.apache.org by "ASF GitHub Bot (JIRA)" <ji...@apache.org> on 2018/02/22 12:34:00 UTC
[jira] [Commented] (WAGON-495) checkoutDirectory leak
[ https://issues.apache.org/jira/browse/WAGON-495?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16372753#comment-16372753 ]
ASF GitHub Bot commented on WAGON-495:
--------------------------------------
GitHub user basinilya opened a pull request:
https://github.com/apache/maven-wagon/pull/46
[WAGON-495] fix testWagonPutDirectoryWhenDirectoryAlreadyExists false positive
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/basinilya/maven-wagon WAGON-495
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/maven-wagon/pull/46.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #46
----
commit 7443918a2255d351241e5edc04ddfcb2cebdcc78
Author: Ilya Basin <ba...@...>
Date: 2018-02-18T19:34:20Z
[WAGON-498] use maven-scm 1.9.6-SNAPSHOT
commit 09d3d542726d189644f0c7de63067afa5f94608d
Author: Ilya Basin <ba...@...>
Date: 2018-02-18T19:49:30Z
[WAGON-498] ScmWagon should work in binary mode when possible
commit c982129f0ad3d34d9d15ed0d7c0659c322a2c7f3
Author: Ilya Basin <ba...@...>
Date: 2018-02-22T08:13:52Z
[WAGON-495] fix testWagonPutDirectoryWhenDirectoryAlreadyExists false
positive
----
> checkoutDirectory leak
> ----------------------
>
> Key: WAGON-495
> URL: https://issues.apache.org/jira/browse/WAGON-495
> Project: Maven Wagon
> Issue Type: Bug
> Components: wagon-scm
> Affects Versions: 3.0.0, 3.0.1
> Reporter: Ilya Basin
> Priority: Major
>
> During deploy artifacts to SVN an instance of ScmWagon is initialized and artifact metadata is downloaded to a local folder. After that maven tries to upload the jar file. ScmWagon.put(File,String) is called which internally overwrites the checkoutDirectory field and checks out the repo again to another temporary folder. The original folder is forgotten.
> Maven uploads jars, poms, checksums and for each file ScmWagon checks out a new directory.
> In the end the closeConnection() method is called which removes the last used folder.
> UPD: this causes false positive in testWagonPutDirectoryWhenDirectoryAlreadyExists(): the test deletes the test checkout dir before calling get(), but the wagon checkout dir remains and the file is retrieved from there.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)