[jira] [Created] (SLING-7085) Remove code duplication

["Radu Cotescu (JIRA)" <ji...@apache.org>]

Radu Cotescu created SLING-7085:
-----------------------------------

             Summary: Remove code duplication
                 Key: SLING-7085
                 URL: https://issues.apache.org/jira/browse/SLING-7085
             Project: Sling
          Issue Type: Bug
          Components: Scripting
    Affects Versions: Scripting HTL Java Compiler 1.0.0, Scripting HTL Compiler 1.0.0, Scripting HTL Engine 1.0.20
            Reporter: Radu Cotescu
            Assignee: Radu Cotescu
             Fix For: Scripting HTL Compiler 1.0.12, Scripting HTL Java Compiler 1.0.12, Scripting HTL Engine 1.0.38


The modularisation of the HTL modules implemented in SLING-5787 introduced some code duplication:

* https://github.com/apache/sling/blob/1aa2c8be782ecb858de9030501e67edc4aba1357/bundles/scripting/sightly/compiler/src/main/java/org/apache/sling/scripting/sightly/impl/compiler/CompileTimeObjectModel.java
* https://github.com/apache/sling/blob/1aa2c8be782ecb858de9030501e67edc4aba1357/bundles/scripting/sightly/java-compiler/src/main/java/org/apache/sling/scripting/sightly/render/AbstractRuntimeObjectModel.java
* https://github.com/apache/sling/blob/1aa2c8be782ecb858de9030501e67edc4aba1357/bundles/scripting/sightly/engine/src/main/java/org/apache/sling/scripting/sightly/impl/engine/runtime/SlingRuntimeObjectModel.java

To reduce code duplication {{CompileTimeObjectModel}} should be exported as {{ObjectModel}} and extend its methods with the specifics of each module needing the functionality.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)