You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@commons.apache.org by gg...@apache.org on 2026/07/25 12:25:40 UTC
(commons-lang) 07/17: Merge if statements with the same return value.
This is an automated email from the ASF dual-hosted git repository.
garydgregory pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/commons-lang.git
commit 6036da7d75bd140a658d9209c6ccac304b1b9a7c
Author: Gary Gregory <ga...@gmail.com>
AuthorDate: Sat Jul 25 08:12:46 2026 -0400
Merge if statements with the same return value.
---
src/main/java/org/apache/commons/lang3/time/FastDateParser.java | 6 +-----
1 file changed, 1 insertion(+), 5 deletions(-)
diff --git a/src/main/java/org/apache/commons/lang3/time/FastDateParser.java b/src/main/java/org/apache/commons/lang3/time/FastDateParser.java
index c638f04a2..01c3df890 100644
--- a/src/main/java/org/apache/commons/lang3/time/FastDateParser.java
+++ b/src/main/java/org/apache/commons/lang3/time/FastDateParser.java
@@ -170,11 +170,7 @@ boolean isNumber() {
boolean parse(final FastDateParser parser, final Calendar calendar, final String source, final ParsePosition pos, final int maxWidth) {
for (int idx = 0; idx < formatField.length(); ++idx) {
final int sIdx = idx + pos.getIndex();
- if (sIdx == source.length()) {
- pos.setErrorIndex(sIdx);
- return false;
- }
- if (formatField.charAt(idx) != source.charAt(sIdx)) {
+ if (sIdx == source.length() || formatField.charAt(idx) != source.charAt(sIdx)) {
pos.setErrorIndex(sIdx);
return false;
}