You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@wicket.apache.org by mg...@apache.org on 2015/06/24 14:58:39 UTC

[33/50] [abbrv] wicket git commit: FindBugs: remove 'synchronized' to #setPageManagerProvider()

FindBugs: remove 'synchronized' to #setPageManagerProvider()

The getter is not synchronized. All other **Provider() methods are also not synchronized.
Usually these methods are called in Application#init() where there is no concurrency.


Project: http://git-wip-us.apache.org/repos/asf/wicket/repo
Commit: http://git-wip-us.apache.org/repos/asf/wicket/commit/c0727f3a
Tree: http://git-wip-us.apache.org/repos/asf/wicket/tree/c0727f3a
Diff: http://git-wip-us.apache.org/repos/asf/wicket/diff/c0727f3a

Branch: refs/heads/master
Commit: c0727f3a6c7300429e85e9784deeb42c99de95a5
Parents: 8021977
Author: Martin Tzvetanov Grigorov <mg...@apache.org>
Authored: Sat Jun 20 16:33:58 2015 +0300
Committer: Martin Tzvetanov Grigorov <mg...@apache.org>
Committed: Wed Jun 24 14:56:34 2015 +0300

----------------------------------------------------------------------
 wicket-core/src/main/java/org/apache/wicket/Application.java | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
----------------------------------------------------------------------


http://git-wip-us.apache.org/repos/asf/wicket/blob/c0727f3a/wicket-core/src/main/java/org/apache/wicket/Application.java
----------------------------------------------------------------------
diff --git a/wicket-core/src/main/java/org/apache/wicket/Application.java b/wicket-core/src/main/java/org/apache/wicket/Application.java
index 056d4ae..f6c3f33 100644
--- a/wicket-core/src/main/java/org/apache/wicket/Application.java
+++ b/wicket-core/src/main/java/org/apache/wicket/Application.java
@@ -1485,7 +1485,7 @@ public abstract class Application implements UnboundListener, IEventSink
 	 * 
 	 * @param provider
 	 */
-	public synchronized final Application setPageManagerProvider(final IPageManagerProvider provider)
+	public final Application setPageManagerProvider(final IPageManagerProvider provider)
 	{
 		pageManagerProvider = provider;
 		return this;