[GitHub] [maven-file-management] cstamas commented on a diff in pull request #11: [MSHARED-1090] Update module

[GitBox <gi...@apache.org>]

cstamas commented on code in PR #11:
URL: https://github.com/apache/maven-file-management/pull/11#discussion_r908929943


##########
src/main/java/org/apache/maven/shared/model/fileset/util/FileSetManager.java:
##########
@@ -61,77 +63,31 @@
     /**
      * Create a new manager instance with the supplied log instance and flag for whether to output verbose messages.
      *
-     * @param log the mojo log instance
+     * @param logger the logger instance
      * @param verbose whether to output verbose messages
      */
-    public FileSetManager( Log log, boolean verbose )
-    {
-        if ( verbose )
-        {
-            this.messages =
-                new MessageHolder( MessageLevels.LEVEL_DEBUG, MessageLevels.LEVEL_INFO, new MojoLogSink( log ) );
-        }
-        else
-        {
-            this.messages =
-                new MessageHolder( MessageLevels.LEVEL_INFO, MessageLevels.LEVEL_INFO, new MojoLogSink( log ) );
-        }
-
-        this.verbose = verbose;
-    }
-
-    /**
-     * Create a new manager instance with the supplied log instance. Verbose flag is set to false.
-     *
-     * @param log The mojo log instance
-     */
-    public FileSetManager( Log log )
+    public FileSetManager( Logger logger, boolean verbose )

Review Comment:
   Disagree, this ctor controls what logger this class will use and verbosity (not level)



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@maven.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org