You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@shindig.apache.org by hs...@apache.org on 2012/09/18 01:35:22 UTC

svn commit: r1386908 - /shindig/trunk/java/gadgets/src/main/java/org/apache/shindig/gadgets/DefaultGuiceModule.java

Author: hsaputra
Date: Mon Sep 17 23:35:21 2012
New Revision: 1386908

URL: http://svn.apache.org/viewvc?rev=1386908&view=rev
Log:
Remove my stupid attempt to make bind JS compiler customize-able. Implementor could always use Modules.override against binding in DefaultGuiceModule

Modified:
    shindig/trunk/java/gadgets/src/main/java/org/apache/shindig/gadgets/DefaultGuiceModule.java

Modified: shindig/trunk/java/gadgets/src/main/java/org/apache/shindig/gadgets/DefaultGuiceModule.java
URL: http://svn.apache.org/viewvc/shindig/trunk/java/gadgets/src/main/java/org/apache/shindig/gadgets/DefaultGuiceModule.java?rev=1386908&r1=1386907&r2=1386908&view=diff
==============================================================================
--- shindig/trunk/java/gadgets/src/main/java/org/apache/shindig/gadgets/DefaultGuiceModule.java (original)
+++ shindig/trunk/java/gadgets/src/main/java/org/apache/shindig/gadgets/DefaultGuiceModule.java Mon Sep 17 23:35:21 2012
@@ -83,11 +83,9 @@ public class DefaultGuiceModule extends 
     install(new SubstituterModule());
     install(new TemplateModule());
     install(new UriModule());
+    install(new JsCompilerModule());
     install(new JsServingPipelineModule());
 
-    // Install the JS Compiler module
-    installJSCompilerModule();
-
     // We perform static injection on HttpResponse for cache TTLs.
     requestStaticInjection(HttpResponse.class);
     requestStaticInjection(AbstractHttpCache.class);
@@ -97,14 +95,6 @@ public class DefaultGuiceModule extends 
   }
 
   /**
-   * Override-able method to install the JS Compiler Module.
-   * Default JS Compiler is bound to DefaultJSCompiler class.
-   */
-  protected void installJSCompilerModule() {
-    install(new JsCompilerModule());
-  }
-
-  /**
    * Sets up multibinding for rpc handlers
    */
   protected void registerGadgetHandlers() {