You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@apisix.apache.org by GitBox <gi...@apache.org> on 2021/07/14 03:00:33 UTC

[GitHub] [apisix-dashboard] foolwc opened a new issue #1980: perf optimization: plugin config drawer onClose has no animation and cannot closed by clicking mask

foolwc opened a new issue #1980:
URL: https://github.com/apache/apisix-dashboard/issues/1980


   ## Issue description
   Plugin config drawer onClose has no animation and cannot close by clicking mask.
   
   ## Expected behavior
   Just like other dawer: consumer view drawer.
   ## How to Reproduce
   
   
   ## Screenshots
   
   ## Environment
   
   * apisix version (cmd: `apisix version`):
   * OS (cmd: `uname -a`):
   * OpenResty / Nginx version (cmd: `nginx -V` or `openresty -V`):
   * etcd version, if have (cmd: run `curl http://127.0.0.1:9090/v1/server_info` to get the info from server-info API):
   * apisix-dashboard version, if have:
   * Browser version, if have:
   
   ## Additional context
   <!-- Do you want to solve this issue? or add any other context about the problem here. -->


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@apisix.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [apisix-dashboard] juzhiyuan closed issue #1980: perf optimization: plugin config drawer onClose has no animation and cannot closed by clicking mask

Posted by GitBox <gi...@apache.org>.
juzhiyuan closed issue #1980:
URL: https://github.com/apache/apisix-dashboard/issues/1980


   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@apisix.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [apisix-dashboard] juzhiyuan commented on issue #1980: perf optimization: plugin config drawer onClose has no animation and cannot closed by clicking mask

Posted by GitBox <gi...@apache.org>.
juzhiyuan commented on issue #1980:
URL: https://github.com/apache/apisix-dashboard/issues/1980#issuecomment-879582161


   This is not a bug, just a configuration from Ant Design component. Why we should allow the click mask to close? Once it's closed, how about the editing data?


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@apisix.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [apisix-dashboard] iamayushdas commented on issue #1980: perf optimization: plugin config drawer onClose has no animation and cannot closed by clicking mask

Posted by GitBox <gi...@apache.org>.
iamayushdas commented on issue #1980:
URL: https://github.com/apache/apisix-dashboard/issues/1980#issuecomment-879548549


   Hmm, Right.
   We should have that feature.
   
   Agree? cc @juzhiyuan @liuxiran 


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@apisix.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [apisix-dashboard] foolwc commented on issue #1980: perf optimization: plugin config drawer onClose has no animation and cannot closed by clicking mask

Posted by GitBox <gi...@apache.org>.
foolwc commented on issue #1980:
URL: https://github.com/apache/apisix-dashboard/issues/1980#issuecomment-879606711


   Maybe we could use Ant Design Drawer component in a uniform way. 


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@apisix.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [apisix-dashboard] juzhiyuan commented on issue #1980: perf optimization: plugin config drawer onClose has no animation and cannot closed by clicking mask

Posted by GitBox <gi...@apache.org>.
juzhiyuan commented on issue #1980:
URL: https://github.com/apache/apisix-dashboard/issues/1980#issuecomment-879636998


   yes, I would prefer keeping the `closeOnMask = false`


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@apisix.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org