You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@solr.apache.org by "David Smiley (Jira)" <ji...@apache.org> on 2025/03/03 16:31:00 UTC
[jira] [Comment Edited] (SOLR-17256) Remove SolrRequest.getBasePath setBasePath
[ https://issues.apache.org/jira/browse/SOLR-17256?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17931714#comment-17931714 ]
David Smiley edited comment on SOLR-17256 at 3/3/25 4:30 PM:
-------------------------------------------------------------
FYI in Solr 9.1 Noble added a very similar concept SolrRequest.getPreferredNodes (and set) and I'm tempted to remove them – see my last comment of SOLR-15715 today.
was (Author: dsmiley):
FYI in Solr 9.1 Noble added a very similar concept SolrRequest.getPreferredNodes (and set) and I'm tempted to remove them – see my last comment of SOLR-17256 today.
> Remove SolrRequest.getBasePath setBasePath
> ------------------------------------------
>
> Key: SOLR-17256
> URL: https://issues.apache.org/jira/browse/SOLR-17256
> Project: Solr
> Issue Type: Improvement
> Components: SolrJ
> Reporter: David Smiley
> Assignee: Jason Gerlowski
> Priority: Minor
> Labels: newdev, pull-request-available
> Fix For: main (10.0), 9.7
>
> Time Spent: 5h 40m
> Remaining Estimate: 0h
>
> SolrRequest has a getBasePath & setBasePath. The naming is poor; it's the URL base to the Solr node like "http://localhost:8983/solr". It's only recognized by HttpSolrClient; LBSolrClient (used by CloudSolrClient) ignores it and will in fact mutate the passed in request to its liking, which is rather ugly because it means a request cannot be used concurrently if the user wants to. But moreover I think there's a conceptual discordance of placing this concept on SolrRequest given that some clients want to route requests to nodes *they* choose. I propose removing this from SolrRequest and instead adding a method specific to HttpSolrClient. Almost all existing usages of setBasePath immediately execute the request on an HttpSolrClient, so should be easy to change.
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@solr.apache.org
For additional commands, e-mail: issues-help@solr.apache.org