[GitHub] WillemJiang commented on a change in pull request #249: SCB-831 fix test case failed on windows environment in LoadBalancedClusterMessageSenderTest

[GitBox <gi...@apache.org>]

WillemJiang commented on a change in pull request #249: SCB-831 fix test case failed on windows environment in LoadBalancedClusterMessageSenderTest
URL: https://github.com/apache/incubator-servicecomb-saga/pull/249#discussion_r209514598
 
 

 ##########
 File path: omega/omega-connector/omega-connector-grpc/src/test/java/org/apache/servicecomb/saga/omega/connector/grpc/LoadBalancedClusterMessageSenderTest.java
 ##########
 @@ -278,6 +278,10 @@ public Boolean call() throws Exception {
     assertThat(eventsMap.get(8080).isEmpty(), is(true));
     assertThat(eventsMap.get(8090).isEmpty(), is(true));
 
+    //it seems in Windows environment we need wait a short time in order to make sure onError in GrpcCompensateStreamObserver triggered
+    // after servers shutdown before restart server
+    Thread.sleep(2000);
 
 Review comment:
   It's better to wait the server terminate instead of just sleep here.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services