You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@flink.apache.org by GitBox <gi...@apache.org> on 2020/11/05 16:31:56 UTC
[GitHub] [flink] vintageplayer opened a new pull request #13951: [FLINK-19998] Fixing links for checkpoints & savepoints in the first …
vintageplayer opened a new pull request #13951:
URL: https://github.com/apache/flink/pull/13951
…section
<!--
*Thank you very much for contributing to Apache Flink - we are happy that you want to help us improve Flink. To help the community review your contribution in the best possible way, please go through the checklist below, which will get the contribution into a shape in which it can be best reviewed.*
*Please understand that we do not do this to make contributions to Flink a hassle. In order to uphold a high standard of quality for code contributions, while at the same time managing a large number of contributions, we need contributors to prepare the contributions well, and give reviewers enough contextual information for the review. Please also understand that contributions that do not follow this guide will take longer to review and thus typically be picked up with lower priority by the community.*
## Contribution Checklist
- Make sure that the pull request corresponds to a [JIRA issue](https://issues.apache.org/jira/projects/FLINK/issues). Exceptions are made for typos in JavaDoc or documentation files, which need no JIRA issue.
- Name the pull request in the form "[FLINK-XXXX] [component] Title of the pull request", where *FLINK-XXXX* should be replaced by the actual issue number. Skip *component* if you are unsure about which is the best component.
Typo fixes that have no associated JIRA issue should be named following this pattern: `[hotfix] [docs] Fix typo in event time introduction` or `[hotfix] [javadocs] Expand JavaDoc for PuncuatedWatermarkGenerator`.
- Fill out the template below to describe the changes contributed by the pull request. That will give reviewers the context they need to do the review.
- Make sure that the change passes the automated tests, i.e., `mvn clean verify` passes. You can set up Azure Pipelines CI to do that following [this guide](https://cwiki.apache.org/confluence/display/FLINK/Azure+Pipelines#AzurePipelines-Tutorial:SettingupAzurePipelinesforaforkoftheFlinkrepository).
- Each pull request should address only one issue, not mix up code from multiple issues.
- Each commit in the pull request has a meaningful commit message (including the JIRA id)
- Once all items of the checklist are addressed, remove the above text and this checklist, leaving only the filled out template below.
**(The sections below can be removed for hotfixes of typos)**
-->
## What is the purpose of the change
*(For example: This pull request makes task deployment go through the blob server, rather than through RPC. That way we avoid re-transferring them on each deployment (during recovery).)*
## Brief change log
*(for example:)*
- *The TaskInfo is stored in the blob store on job creation time as a persistent artifact*
- *Deployments RPC transmits only the blob storage reference*
- *TaskManagers retrieve the TaskInfo from the blob cache*
## Verifying this change
*(Please pick either of the following options)*
This change is a trivial rework / code cleanup without any test coverage.
*(or)*
This change is already covered by existing tests, such as *(please describe tests)*.
*(or)*
This change added tests and can be verified as follows:
*(example:)*
- *Added integration tests for end-to-end deployment with large payloads (100MB)*
- *Extended integration test for recovery after master (JobManager) failure*
- *Added test that validates that TaskInfo is transferred only once across recoveries*
- *Manually verified the change by running a 4 node cluser with 2 JobManagers and 4 TaskManagers, a stateful streaming program, and killing one JobManager and two TaskManagers during the execution, verifying that recovery happens correctly.*
## Does this pull request potentially affect one of the following parts:
- Dependencies (does it add or upgrade a dependency): (yes / no)
- The public API, i.e., is any changed class annotated with `@Public(Evolving)`: (yes / no)
- The serializers: (yes / no / don't know)
- The runtime per-record code paths (performance sensitive): (yes / no / don't know)
- Anything that affects deployment or recovery: JobManager (and its components), Checkpointing, Kubernetes/Yarn/Mesos, ZooKeeper: (yes / no / don't know)
- The S3 file system connector: (yes / no / don't know)
## Documentation
- Does this pull request introduce a new feature? (yes / no)
- If yes, how is the feature documented? (not applicable / docs / JavaDocs / not documented)
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #13951: [FLINK-19998] Fixing Invalid Links in docs
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #13951:
URL: https://github.com/apache/flink/pull/13951#issuecomment-722570395
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "2141fffab91e4f7cd38630026ef48fc503a4fac6",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=9115",
"triggerID" : "2141fffab91e4f7cd38630026ef48fc503a4fac6",
"triggerType" : "PUSH"
}, {
"hash" : "e09a33730450ddd3d4e9393e49711b7708f2e323",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=9531",
"triggerID" : "e09a33730450ddd3d4e9393e49711b7708f2e323",
"triggerType" : "PUSH"
}, {
"hash" : "1baeb50448b6fe0453b88cc81d836907ef4d2937",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=9537",
"triggerID" : "1baeb50448b6fe0453b88cc81d836907ef4d2937",
"triggerType" : "PUSH"
}, {
"hash" : "ee27c0379616fbe6b4e8c98dce8ebf93ab79af4e",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=9907",
"triggerID" : "ee27c0379616fbe6b4e8c98dce8ebf93ab79af4e",
"triggerType" : "PUSH"
}, {
"hash" : "6d1f85d192f3e7c5672c4a711417438f0596b114",
"status" : "SUCCESS",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=10131",
"triggerID" : "6d1f85d192f3e7c5672c4a711417438f0596b114",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 6d1f85d192f3e7c5672c4a711417438f0596b114 Azure: [SUCCESS](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=10131)
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
</details>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] vintageplayer commented on pull request #13951: [FLINK-19998] Fixing links for checkpoints & savepoints in the first …
Posted by GitBox <gi...@apache.org>.
vintageplayer commented on pull request #13951:
URL: https://github.com/apache/flink/pull/13951#issuecomment-723928749
> I think this bug is caused by mix usage of `{ site.baseurl}}` and `% link`, we might expend previous JIRA ticket and fix all broken links by searching `site.baseurl }}{% link`, `site.baseurl}}{% link` and so on.
I've a regex. Can I update the same pull request? Or should I create a new one abandoning this?
@Myasuka
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] Myasuka merged pull request #13951: [FLINK-19998] Fixing Invalid Links in docs
Posted by GitBox <gi...@apache.org>.
Myasuka merged pull request #13951:
URL: https://github.com/apache/flink/pull/13951
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #13951: [FLINK-19998] Fixing Invalid Links in docs
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #13951:
URL: https://github.com/apache/flink/pull/13951#issuecomment-722570395
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "2141fffab91e4f7cd38630026ef48fc503a4fac6",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=9115",
"triggerID" : "2141fffab91e4f7cd38630026ef48fc503a4fac6",
"triggerType" : "PUSH"
}, {
"hash" : "e09a33730450ddd3d4e9393e49711b7708f2e323",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=9531",
"triggerID" : "e09a33730450ddd3d4e9393e49711b7708f2e323",
"triggerType" : "PUSH"
}, {
"hash" : "1baeb50448b6fe0453b88cc81d836907ef4d2937",
"status" : "SUCCESS",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=9537",
"triggerID" : "1baeb50448b6fe0453b88cc81d836907ef4d2937",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 1baeb50448b6fe0453b88cc81d836907ef4d2937 Azure: [SUCCESS](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=9537)
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
</details>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] Myasuka commented on pull request #13951: [FLINK-19998] Fixing links for checkpoints & savepoints in the first …
Posted by GitBox <gi...@apache.org>.
Myasuka commented on pull request #13951:
URL: https://github.com/apache/flink/pull/13951#issuecomment-723930622
I think you could extend current JIRA's description and update current PR. This is just documentation link fix and caused by the same reason, we don't need to distinguish what the actual content said.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #13951: [FLINK-19998] Fixing links for checkpoints & savepoints in the first …
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #13951:
URL: https://github.com/apache/flink/pull/13951#issuecomment-722570395
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "2141fffab91e4f7cd38630026ef48fc503a4fac6",
"status" : "SUCCESS",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=9115",
"triggerID" : "2141fffab91e4f7cd38630026ef48fc503a4fac6",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 2141fffab91e4f7cd38630026ef48fc503a4fac6 Azure: [SUCCESS](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=9115)
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
</details>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #13951: [FLINK-19998] Fixing Invalid Links in docs
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #13951:
URL: https://github.com/apache/flink/pull/13951#issuecomment-722570395
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "2141fffab91e4f7cd38630026ef48fc503a4fac6",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=9115",
"triggerID" : "2141fffab91e4f7cd38630026ef48fc503a4fac6",
"triggerType" : "PUSH"
}, {
"hash" : "e09a33730450ddd3d4e9393e49711b7708f2e323",
"status" : "FAILURE",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=9531",
"triggerID" : "e09a33730450ddd3d4e9393e49711b7708f2e323",
"triggerType" : "PUSH"
}, {
"hash" : "1baeb50448b6fe0453b88cc81d836907ef4d2937",
"status" : "PENDING",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=9537",
"triggerID" : "1baeb50448b6fe0453b88cc81d836907ef4d2937",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* e09a33730450ddd3d4e9393e49711b7708f2e323 Azure: [FAILURE](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=9531)
* 1baeb50448b6fe0453b88cc81d836907ef4d2937 Azure: [PENDING](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=9537)
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
</details>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #13951: [FLINK-19998] Fixing Invalid Links in docs
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #13951:
URL: https://github.com/apache/flink/pull/13951#issuecomment-722570395
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "2141fffab91e4f7cd38630026ef48fc503a4fac6",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=9115",
"triggerID" : "2141fffab91e4f7cd38630026ef48fc503a4fac6",
"triggerType" : "PUSH"
}, {
"hash" : "e09a33730450ddd3d4e9393e49711b7708f2e323",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=9531",
"triggerID" : "e09a33730450ddd3d4e9393e49711b7708f2e323",
"triggerType" : "PUSH"
}, {
"hash" : "1baeb50448b6fe0453b88cc81d836907ef4d2937",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=9537",
"triggerID" : "1baeb50448b6fe0453b88cc81d836907ef4d2937",
"triggerType" : "PUSH"
}, {
"hash" : "ee27c0379616fbe6b4e8c98dce8ebf93ab79af4e",
"status" : "SUCCESS",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=9907",
"triggerID" : "ee27c0379616fbe6b4e8c98dce8ebf93ab79af4e",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* ee27c0379616fbe6b4e8c98dce8ebf93ab79af4e Azure: [SUCCESS](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=9907)
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
</details>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #13951: [FLINK-19998] Fixing Invalid Links in docs
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #13951:
URL: https://github.com/apache/flink/pull/13951#issuecomment-722570395
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "2141fffab91e4f7cd38630026ef48fc503a4fac6",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=9115",
"triggerID" : "2141fffab91e4f7cd38630026ef48fc503a4fac6",
"triggerType" : "PUSH"
}, {
"hash" : "e09a33730450ddd3d4e9393e49711b7708f2e323",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=9531",
"triggerID" : "e09a33730450ddd3d4e9393e49711b7708f2e323",
"triggerType" : "PUSH"
}, {
"hash" : "1baeb50448b6fe0453b88cc81d836907ef4d2937",
"status" : "SUCCESS",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=9537",
"triggerID" : "1baeb50448b6fe0453b88cc81d836907ef4d2937",
"triggerType" : "PUSH"
}, {
"hash" : "ee27c0379616fbe6b4e8c98dce8ebf93ab79af4e",
"status" : "PENDING",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=9907",
"triggerID" : "ee27c0379616fbe6b4e8c98dce8ebf93ab79af4e",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 1baeb50448b6fe0453b88cc81d836907ef4d2937 Azure: [SUCCESS](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=9537)
* ee27c0379616fbe6b4e8c98dce8ebf93ab79af4e Azure: [PENDING](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=9907)
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
</details>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #13951: [FLINK-19998] Fixing Invalid Links in docs
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #13951:
URL: https://github.com/apache/flink/pull/13951#issuecomment-722570395
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "2141fffab91e4f7cd38630026ef48fc503a4fac6",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=9115",
"triggerID" : "2141fffab91e4f7cd38630026ef48fc503a4fac6",
"triggerType" : "PUSH"
}, {
"hash" : "e09a33730450ddd3d4e9393e49711b7708f2e323",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=9531",
"triggerID" : "e09a33730450ddd3d4e9393e49711b7708f2e323",
"triggerType" : "PUSH"
}, {
"hash" : "1baeb50448b6fe0453b88cc81d836907ef4d2937",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=9537",
"triggerID" : "1baeb50448b6fe0453b88cc81d836907ef4d2937",
"triggerType" : "PUSH"
}, {
"hash" : "ee27c0379616fbe6b4e8c98dce8ebf93ab79af4e",
"status" : "SUCCESS",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=9907",
"triggerID" : "ee27c0379616fbe6b4e8c98dce8ebf93ab79af4e",
"triggerType" : "PUSH"
}, {
"hash" : "6d1f85d192f3e7c5672c4a711417438f0596b114",
"status" : "PENDING",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=10131",
"triggerID" : "6d1f85d192f3e7c5672c4a711417438f0596b114",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* ee27c0379616fbe6b4e8c98dce8ebf93ab79af4e Azure: [SUCCESS](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=9907)
* 6d1f85d192f3e7c5672c4a711417438f0596b114 Azure: [PENDING](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=10131)
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
</details>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] Myasuka edited a comment on pull request #13951: [FLINK-19998] Fixing links for checkpoints & savepoints in the first …
Posted by GitBox <gi...@apache.org>.
Myasuka edited a comment on pull request #13951:
URL: https://github.com/apache/flink/pull/13951#issuecomment-723930622
I think you could extend current JIRA's description and update current PR. This is just documentation link fix and caused by the same reason, we don't need to distinguish what the actual content said.
You could combine new updates with current as one commit and force update your branch for PR.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] vintageplayer commented on pull request #13951: [FLINK-19998] Fixing Invalid Links in docs
Posted by GitBox <gi...@apache.org>.
vintageplayer commented on pull request #13951:
URL: https://github.com/apache/flink/pull/13951#issuecomment-726296371
> I think you could extend current JIRA's description and update current PR. This is just documentation link fix and caused by the same reason, we don't need to distinguish what the actual content said.
>
> You could combine new updates with current as one commit and force update your branch for PR.
The pull request is updated with the new commit. Please review @Myasuka
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] Myasuka edited a comment on pull request #13951: [FLINK-19998] Fixing Invalid Links in docs
Posted by GitBox <gi...@apache.org>.
Myasuka edited a comment on pull request #13951:
URL: https://github.com/apache/flink/pull/13951#issuecomment-731897664
LGTM, @vintageplayer please rename the commit title (not the PR title) as `[FLINK-19998] Remove site.baseurl from {% link %} tags` and I'll then merge this PR.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #13951: [FLINK-19998] Fixing Invalid Links in docs
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #13951:
URL: https://github.com/apache/flink/pull/13951#issuecomment-722570395
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "2141fffab91e4f7cd38630026ef48fc503a4fac6",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=9115",
"triggerID" : "2141fffab91e4f7cd38630026ef48fc503a4fac6",
"triggerType" : "PUSH"
}, {
"hash" : "e09a33730450ddd3d4e9393e49711b7708f2e323",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=9531",
"triggerID" : "e09a33730450ddd3d4e9393e49711b7708f2e323",
"triggerType" : "PUSH"
}, {
"hash" : "1baeb50448b6fe0453b88cc81d836907ef4d2937",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=9537",
"triggerID" : "1baeb50448b6fe0453b88cc81d836907ef4d2937",
"triggerType" : "PUSH"
}, {
"hash" : "ee27c0379616fbe6b4e8c98dce8ebf93ab79af4e",
"status" : "SUCCESS",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=9907",
"triggerID" : "ee27c0379616fbe6b4e8c98dce8ebf93ab79af4e",
"triggerType" : "PUSH"
}, {
"hash" : "6d1f85d192f3e7c5672c4a711417438f0596b114",
"status" : "UNKNOWN",
"url" : "TBD",
"triggerID" : "6d1f85d192f3e7c5672c4a711417438f0596b114",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* ee27c0379616fbe6b4e8c98dce8ebf93ab79af4e Azure: [SUCCESS](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=9907)
* 6d1f85d192f3e7c5672c4a711417438f0596b114 UNKNOWN
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
</details>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #13951: [FLINK-19998] Fixing Invalid Links in docs
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #13951:
URL: https://github.com/apache/flink/pull/13951#issuecomment-722570395
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "2141fffab91e4f7cd38630026ef48fc503a4fac6",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=9115",
"triggerID" : "2141fffab91e4f7cd38630026ef48fc503a4fac6",
"triggerType" : "PUSH"
}, {
"hash" : "e09a33730450ddd3d4e9393e49711b7708f2e323",
"status" : "FAILURE",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=9531",
"triggerID" : "e09a33730450ddd3d4e9393e49711b7708f2e323",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* e09a33730450ddd3d4e9393e49711b7708f2e323 Azure: [FAILURE](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=9531)
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
</details>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] vintageplayer edited a comment on pull request #13951: [FLINK-19998] Fixing links for checkpoints & savepoints in the first …
Posted by GitBox <gi...@apache.org>.
vintageplayer edited a comment on pull request #13951:
URL: https://github.com/apache/flink/pull/13951#issuecomment-723928749
> I think this bug is caused by mix usage of `{ site.baseurl}}` and `% link`, we might expend previous JIRA ticket and fix all broken links by searching `site.baseurl }}{% link`, `site.baseurl}}{% link` and so on.
I've a regex. Can I update the same pull request? Or should I create a new one, and abandon this one?
@Myasuka
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] vintageplayer commented on pull request #13951: [FLINK-19998] Fixing links for checkpoints & savepoints in the first …
Posted by GitBox <gi...@apache.org>.
vintageplayer commented on pull request #13951:
URL: https://github.com/apache/flink/pull/13951#issuecomment-722862235
@rmetzger Have updated the pull request description. Please take a look. Thanks.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] Myasuka commented on pull request #13951: [FLINK-19998] Fixing Invalid Links in docs
Posted by GitBox <gi...@apache.org>.
Myasuka commented on pull request #13951:
URL: https://github.com/apache/flink/pull/13951#issuecomment-731897664
LGTM, @vintageplayer please rename the commit title as `[FLINK-19998] Remove site.baseurl from {% link %} tags` and I'll then merge this PR.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #13951: [FLINK-19998] Fixing links for checkpoints & savepoints in the first …
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #13951:
URL: https://github.com/apache/flink/pull/13951#issuecomment-722570395
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "2141fffab91e4f7cd38630026ef48fc503a4fac6",
"status" : "SUCCESS",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=9115",
"triggerID" : "2141fffab91e4f7cd38630026ef48fc503a4fac6",
"triggerType" : "PUSH"
}, {
"hash" : "e09a33730450ddd3d4e9393e49711b7708f2e323",
"status" : "PENDING",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=9531",
"triggerID" : "e09a33730450ddd3d4e9393e49711b7708f2e323",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 2141fffab91e4f7cd38630026ef48fc503a4fac6 Azure: [SUCCESS](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=9115)
* e09a33730450ddd3d4e9393e49711b7708f2e323 Azure: [PENDING](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=9531)
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
</details>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #13951: [FLINK-19998] Fixing links for checkpoints & savepoints in the first …
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #13951:
URL: https://github.com/apache/flink/pull/13951#issuecomment-722570395
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "2141fffab91e4f7cd38630026ef48fc503a4fac6",
"status" : "SUCCESS",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=9115",
"triggerID" : "2141fffab91e4f7cd38630026ef48fc503a4fac6",
"triggerType" : "PUSH"
}, {
"hash" : "e09a33730450ddd3d4e9393e49711b7708f2e323",
"status" : "UNKNOWN",
"url" : "TBD",
"triggerID" : "e09a33730450ddd3d4e9393e49711b7708f2e323",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 2141fffab91e4f7cd38630026ef48fc503a4fac6 Azure: [SUCCESS](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=9115)
* e09a33730450ddd3d4e9393e49711b7708f2e323 UNKNOWN
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
</details>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot commented on pull request #13951: [FLINK-19998] Fixing links for checkpoints & savepoints in the first …
Posted by GitBox <gi...@apache.org>.
flinkbot commented on pull request #13951:
URL: https://github.com/apache/flink/pull/13951#issuecomment-722570395
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "2141fffab91e4f7cd38630026ef48fc503a4fac6",
"status" : "UNKNOWN",
"url" : "TBD",
"triggerID" : "2141fffab91e4f7cd38630026ef48fc503a4fac6",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 2141fffab91e4f7cd38630026ef48fc503a4fac6 UNKNOWN
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
</details>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #13951: [FLINK-19998] Fixing Invalid Links in docs
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #13951:
URL: https://github.com/apache/flink/pull/13951#issuecomment-722570395
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "2141fffab91e4f7cd38630026ef48fc503a4fac6",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=9115",
"triggerID" : "2141fffab91e4f7cd38630026ef48fc503a4fac6",
"triggerType" : "PUSH"
}, {
"hash" : "e09a33730450ddd3d4e9393e49711b7708f2e323",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=9531",
"triggerID" : "e09a33730450ddd3d4e9393e49711b7708f2e323",
"triggerType" : "PUSH"
}, {
"hash" : "1baeb50448b6fe0453b88cc81d836907ef4d2937",
"status" : "SUCCESS",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=9537",
"triggerID" : "1baeb50448b6fe0453b88cc81d836907ef4d2937",
"triggerType" : "PUSH"
}, {
"hash" : "ee27c0379616fbe6b4e8c98dce8ebf93ab79af4e",
"status" : "UNKNOWN",
"url" : "TBD",
"triggerID" : "ee27c0379616fbe6b4e8c98dce8ebf93ab79af4e",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 1baeb50448b6fe0453b88cc81d836907ef4d2937 Azure: [SUCCESS](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=9537)
* ee27c0379616fbe6b4e8c98dce8ebf93ab79af4e UNKNOWN
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
</details>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] Myasuka commented on pull request #13951: [FLINK-19998] Fixing Invalid Links in docs
Posted by GitBox <gi...@apache.org>.
Myasuka commented on pull request #13951:
URL: https://github.com/apache/flink/pull/13951#issuecomment-732687372
@vintageplayer Could you please help rename the commit title so that I could directly merge your commit?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot commented on pull request #13951: [FLINK-19998] Fixing links for checkpoints & savepoints in the first …
Posted by GitBox <gi...@apache.org>.
flinkbot commented on pull request #13951:
URL: https://github.com/apache/flink/pull/13951#issuecomment-722490503
Thanks a lot for your contribution to the Apache Flink project. I'm the @flinkbot. I help the community
to review your pull request. We will use this comment to track the progress of the review.
## Automated Checks
Last check on commit 2141fffab91e4f7cd38630026ef48fc503a4fac6 (Thu Nov 05 16:34:18 UTC 2020)
✅no warnings
<sub>Mention the bot in a comment to re-run the automated checks.</sub>
## Review Progress
* ❓ 1. The [description] looks good.
* ❓ 2. There is [consensus] that the contribution should go into to Flink.
* ❓ 3. Needs [attention] from.
* ❓ 4. The change fits into the overall [architecture].
* ❓ 5. Overall code [quality] is good.
Please see the [Pull Request Review Guide](https://flink.apache.org/contributing/reviewing-prs.html) for a full explanation of the review process.<details>
The Bot is tracking the review progress through labels. Labels are applied according to the order of the review items. For consensus, approval by a Flink committer of PMC member is required <summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot approve description` to approve one or more aspects (aspects: `description`, `consensus`, `architecture` and `quality`)
- `@flinkbot approve all` to approve all aspects
- `@flinkbot approve-until architecture` to approve everything until `architecture`
- `@flinkbot attention @username1 [@username2 ..]` to require somebody's attention
- `@flinkbot disapprove architecture` to remove an approval you gave earlier
</details>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #13951: [FLINK-19998] Fixing Invalid Links in docs
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #13951:
URL: https://github.com/apache/flink/pull/13951#issuecomment-722570395
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "2141fffab91e4f7cd38630026ef48fc503a4fac6",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=9115",
"triggerID" : "2141fffab91e4f7cd38630026ef48fc503a4fac6",
"triggerType" : "PUSH"
}, {
"hash" : "e09a33730450ddd3d4e9393e49711b7708f2e323",
"status" : "FAILURE",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=9531",
"triggerID" : "e09a33730450ddd3d4e9393e49711b7708f2e323",
"triggerType" : "PUSH"
}, {
"hash" : "1baeb50448b6fe0453b88cc81d836907ef4d2937",
"status" : "UNKNOWN",
"url" : "TBD",
"triggerID" : "1baeb50448b6fe0453b88cc81d836907ef4d2937",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* e09a33730450ddd3d4e9393e49711b7708f2e323 Azure: [FAILURE](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=9531)
* 1baeb50448b6fe0453b88cc81d836907ef4d2937 UNKNOWN
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
</details>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org