[GitHub] [hbase] Apache-HBase commented on a change in pull request #251: HBASE-22114 Port HBASE-15560 (TinyLFU-based BlockCache) to branch-1

[GitBox <gi...@apache.org>]

Apache-HBase commented on a change in pull request #251: HBASE-22114 Port HBASE-15560 (TinyLFU-based BlockCache) to branch-1
URL: https://github.com/apache/hbase/pull/251#discussion_r293271923
 
 

 ##########
 File path: dev-support/hbase-personality.sh
 ##########
 @@ -117,6 +117,12 @@ function personality_modules
   extra="-DHBasePatchProcess"
   if [[ "${PATCH_BRANCH}" = branch-1* ]]; then
     extra="${extra} -Dhttps.protocols=TLSv1.2"
+    # on branches-1, the hbase-tinylfu-blockcache only works for jdk8. so if it changes
+    # run whatever test is requested at the top level so that maven can handle only including
+    # the module when the correct jdk is around.
+    if [[ "${MODULES[*]}" =~ hbase-tinylfu-blockcache ]]; then
 
 Review comment:
   shellcheck:25: warning: Did you forget to close this double quoted string? [SC1078]
   

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services