You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@nuttx.apache.org by GitBox <gi...@apache.org> on 2022/01/04 12:54:27 UTC

[GitHub] [incubator-nuttx] no1wudi opened a new pull request #5160: arch/risc-v: Replace __LP64__ with CONFIG_ARCH_RV64

no1wudi opened a new pull request #5160:
URL: https://github.com/apache/incubator-nuttx/pull/5160


   ## Summary
   It can provide better auto complete experience for modern code editor,
   since they use clang/gcc based parser to analyze code but lacks some
   target dependent info such as __LP64__ for riscv64.
   ## Impact
   None
   ## Testing
   CI
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@nuttx.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [incubator-nuttx] xiaoxiang781216 commented on a change in pull request #5160: arch/risc-v: Replace __LP64__ with CONFIG_ARCH_RV64

Posted by GitBox <gi...@apache.org>.
xiaoxiang781216 commented on a change in pull request #5160:
URL: https://github.com/apache/incubator-nuttx/pull/5160#discussion_r778061230



##########
File path: arch/risc-v/include/spinlock.h
##########
@@ -78,7 +78,7 @@
  * RISC-V architecture supports fence instruction to ensure memory ordering
  */
 
-#ifdef __LP64__
+#ifdef CONFIG_ARCH_RV64
 typedef uint64_t spinlock_t;

Review comment:
       can we change uint64_t to uintptr_t? and then remove __LP64__/CONFIG_ARCH_RV64 check.




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@nuttx.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [incubator-nuttx] xiaoxiang781216 merged pull request #5160: arch/risc-v: Replace __LP64__ with CONFIG_ARCH_RV64

Posted by GitBox <gi...@apache.org>.
xiaoxiang781216 merged pull request #5160:
URL: https://github.com/apache/incubator-nuttx/pull/5160


   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@nuttx.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org