You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@airflow.apache.org by GitBox <gi...@apache.org> on 2020/08/31 23:07:55 UTC

[GitHub] [airflow] potiuk opened a new pull request #10670: Add packages to function names in bash

potiuk opened a new pull request #10670:
URL: https://github.com/apache/airflow/pull/10670


   Inspired by the Google Shell Guide where they mentioned
   separating package names with :: I realized that this was
   one of the missing pieces in the bash scripts of ours.
   
   While we already had packages (in libraries folders)
   it's been difficult to realise which function is where.
   
   With introducing packages - equal to the library file name
   we are *almost* at a level of a structured language - and
   it's easier to find the functions if you are looking for them.
   
   Way easier in fact.
   
   Part of #10576
   
   ---
   **^ Add meaningful description above**
   
   Read the **[Pull Request Guidelines](https://github.com/apache/airflow/blob/master/CONTRIBUTING.rst#pull-request-guidelines)** for more information.
   In case of fundamental code change, Airflow Improvement Proposal ([AIP](https://cwiki.apache.org/confluence/display/AIRFLOW/Airflow+Improvements+Proposals)) is needed.
   In case of a new dependency, check compliance with the [ASF 3rd Party License Policy](https://www.apache.org/legal/resolved.html#category-x).
   In case of backwards incompatible changes please leave a note in [UPDATING.md](https://github.com/apache/airflow/blob/master/UPDATING.md).
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [airflow] potiuk commented on pull request #10670: Add packages to function names in bash

Posted by GitBox <gi...@apache.org>.
potiuk commented on pull request #10670:
URL: https://github.com/apache/airflow/pull/10670#issuecomment-684104998


   cc: @OmairK 


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [airflow] potiuk merged pull request #10670: Add packages to function names in bash

Posted by GitBox <gi...@apache.org>.
potiuk merged pull request #10670:
URL: https://github.com/apache/airflow/pull/10670


   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [airflow] potiuk commented on pull request #10670: Add packages to function names in bash

Posted by GitBox <gi...@apache.org>.
potiuk commented on pull request #10670:
URL: https://github.com/apache/airflow/pull/10670#issuecomment-684516991


   All green !


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org