Re: svn commit: r439352 - in /maven/components/trunk: ./ maven-artifact-manager/ maven-artifact-manager/src/main/java/org/apache/maven/artifact/repository/metadata/ maven-artifact-manager/src/test/java/org/apache/maven/artifact/repository/ maven-artifact-m...

[Brett Porter <br...@apache.org>]

On 02/09/2006, at 1:29 AM, jdcasey@apache.org wrote:

>
> Modified: maven/components/trunk/maven-artifact-manager/pom.xml
> URL: http://svn.apache.org/viewvc/maven/components/trunk/maven- 
> artifact-manager/pom.xml?rev=439352&r1=439351&r2=439352&view=diff
> ====================================================================== 
> ========
> --- maven/components/trunk/maven-artifact-manager/pom.xml (original)
> +++ maven/components/trunk/maven-artifact-manager/pom.xml Fri Sep   
> 1 08:29:52 2006
> @@ -54,5 +54,9 @@
>        <groupId>org.apache.maven.wagon</groupId>
>        <artifactId>wagon-provider-api</artifactId>
>      </dependency>
> +    <dependency>
> +      <groupId>easymock</groupId>
> +      <artifactId>easymock</artifactId>
> +    </dependency>
>    </dependencies>
>  </project>

I didnt think depMgmt managed scopes?

>
> +    private static final class TestRepoMetadata
> +        extends AbstractRepositoryMetadata

Why was this needed when you are mocking the other things? Not sure I  
understand.

> +
> +public class MockManager

I'm not sure of the value of this, but it's an interesting approach.  
Shouldn't it be separate to artifact-manager though?

> +public class TestFileManager

I don't understand this code either. For the user, this seems to be  
just as verbose as:
File f = File.createTempFile( ... );
f.deleteOnExit();

Most of the rest seems to duplicate FileUtils code.

If we're going to start assembling some test utilities, that's cool,  
but we should put it in shared and agreed we are going to use it  
consistently. One of the pitfalls of testing the current codebase is  
that you don't know which to use, and where (especially when it comes  
to plugin and integration testing)

- Brett

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@maven.apache.org
For additional commands, e-mail: dev-help@maven.apache.org