[GitHub] storm issue #2161: STORM-2556 Break down AutoCreds implementations into two ...

[revans2 <gi...@git.apache.org>]

Github user revans2 commented on the issue:

    https://github.com/apache/storm/pull/2161
  
    I am fine with splitting things up, but I am not super excited about how we setup the Abstract* classes.  Perhaps it is just how we are naming them, because there are a lot of things in them that are very Hadoop specific, aka UserGroupInformation.  Could we at least rename the current set of Abstract base classes to have Hadoop somewhere in the name?  If you want to go overboard we could look at truly providing a generic base class for credentials that has pluggable pieces for pulling out the raw string credentials (similar to CredentialKeyProvider), deserializing them, and putting them in the Subject correctly.  Then on the other side getting the credentials, serializing them to a string, and finally putting them into the string credentials object (again similar to CredentialKeyProvider).


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---