You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@mesos.apache.org by Ben Mahler <be...@gmail.com> on 2013/03/20 00:54:07 UTC
Review Request: Fixed the GC of terminated executor directories in the
slave. The directories are also unscheduled for gc,
when launching another executor of the same id.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/10032/
-----------------------------------------------------------
Review request for mesos, Benjamin Hindman and Vinod Kone.
Description
-------
This does some restructuring of runTask() in the slave, in order to support the asynchronous gc.unschedule() operation of existing executor directories.
This addresses bug MESOS-396.
https://issues.apache.org/jira/browse/MESOS-396
Diffs
-----
src/slave/slave.hpp dadd06850565d07b46cea2f581661fb57a121118
src/slave/slave.cpp 912499e4cb34afa9bcc1556fd9536581001933ca
src/tests/gc_tests.cpp a9a7a439702ab87d5384c2d1b8afc0b17dab4e62
src/tests/utils.hpp 50203579f1ea14ee751c12a373047e9295e4ebb3
Diff: https://reviews.apache.org/r/10032/diff/
Testing
-------
Added an integration test for restarted executors.
Thanks,
Ben Mahler
Re: Review Request: Fixed the GC of terminated executor directories in the
slave. The directories are also unscheduled for gc,
when launching another executor of the same id.
Posted by Ben Mahler <be...@gmail.com>.
> On April 17, 2013, 4:59 p.m., Vinod Kone wrote:
> > can you drop this review now?
discarded
- Ben
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/10032/#review19323
-----------------------------------------------------------
On March 19, 2013, 11:54 p.m., Ben Mahler wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/10032/
> -----------------------------------------------------------
>
> (Updated March 19, 2013, 11:54 p.m.)
>
>
> Review request for mesos, Benjamin Hindman and Vinod Kone.
>
>
> Description
> -------
>
> This does some restructuring of runTask() in the slave, in order to support the asynchronous gc.unschedule() operation of existing executor directories.
>
>
> This addresses bug MESOS-396.
> https://issues.apache.org/jira/browse/MESOS-396
>
>
> Diffs
> -----
>
> src/slave/slave.hpp dadd06850565d07b46cea2f581661fb57a121118
> src/slave/slave.cpp 912499e4cb34afa9bcc1556fd9536581001933ca
> src/tests/gc_tests.cpp a9a7a439702ab87d5384c2d1b8afc0b17dab4e62
> src/tests/utils.hpp 50203579f1ea14ee751c12a373047e9295e4ebb3
>
> Diff: https://reviews.apache.org/r/10032/diff/
>
>
> Testing
> -------
>
> Added an integration test for restarted executors.
>
>
> Thanks,
>
> Ben Mahler
>
>
Re: Review Request: Fixed the GC of terminated executor directories in the
slave. The directories are also unscheduled for gc,
when launching another executor of the same id.
Posted by Vinod Kone <vi...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/10032/#review19323
-----------------------------------------------------------
can you drop this review now?
- Vinod Kone
On March 19, 2013, 11:54 p.m., Ben Mahler wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/10032/
> -----------------------------------------------------------
>
> (Updated March 19, 2013, 11:54 p.m.)
>
>
> Review request for mesos, Benjamin Hindman and Vinod Kone.
>
>
> Description
> -------
>
> This does some restructuring of runTask() in the slave, in order to support the asynchronous gc.unschedule() operation of existing executor directories.
>
>
> This addresses bug MESOS-396.
> https://issues.apache.org/jira/browse/MESOS-396
>
>
> Diffs
> -----
>
> src/slave/slave.hpp dadd06850565d07b46cea2f581661fb57a121118
> src/slave/slave.cpp 912499e4cb34afa9bcc1556fd9536581001933ca
> src/tests/gc_tests.cpp a9a7a439702ab87d5384c2d1b8afc0b17dab4e62
> src/tests/utils.hpp 50203579f1ea14ee751c12a373047e9295e4ebb3
>
> Diff: https://reviews.apache.org/r/10032/diff/
>
>
> Testing
> -------
>
> Added an integration test for restarted executors.
>
>
> Thanks,
>
> Ben Mahler
>
>
Re: Review Request: Fixed the GC of terminated executor directories in the
slave. The directories are also unscheduled for gc,
when launching another executor of the same id.
Posted by Ben Mahler <be...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/10032/#review18165
-----------------------------------------------------------
src/slave/slave.cpp
<https://reviews.apache.org/r/10032/#comment38320>
This implies that the slave received a request to shut down the framework in the interim. We should log a descriptive warning here, and then send a TASK_LOST.
- Ben Mahler
On March 19, 2013, 11:54 p.m., Ben Mahler wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/10032/
> -----------------------------------------------------------
>
> (Updated March 19, 2013, 11:54 p.m.)
>
>
> Review request for mesos, Benjamin Hindman and Vinod Kone.
>
>
> Description
> -------
>
> This does some restructuring of runTask() in the slave, in order to support the asynchronous gc.unschedule() operation of existing executor directories.
>
>
> This addresses bug MESOS-396.
> https://issues.apache.org/jira/browse/MESOS-396
>
>
> Diffs
> -----
>
> src/slave/slave.hpp dadd06850565d07b46cea2f581661fb57a121118
> src/slave/slave.cpp 912499e4cb34afa9bcc1556fd9536581001933ca
> src/tests/gc_tests.cpp a9a7a439702ab87d5384c2d1b8afc0b17dab4e62
> src/tests/utils.hpp 50203579f1ea14ee751c12a373047e9295e4ebb3
>
> Diff: https://reviews.apache.org/r/10032/diff/
>
>
> Testing
> -------
>
> Added an integration test for restarted executors.
>
>
> Thanks,
>
> Ben Mahler
>
>