[GitHub] [ozone] Xushaohong commented on a change in pull request #3121: HDDS-6357. RenameKey request has memory leak

[GitBox <gi...@apache.org>]

Xushaohong commented on a change in pull request #3121:
URL: https://github.com/apache/ozone/pull/3121#discussion_r814618667



##########
File path: hadoop-hdds/framework/src/main/java/org/apache/hadoop/hdds/utils/db/cache/FullTableCache.java
##########
@@ -187,8 +191,8 @@ public void evictCache(List<Long> epochs) {
 
   @VisibleForTesting
   @Override
-  public Set<EpochEntry<CACHEKEY>> getEpochEntrySet() {
-    return epochEntries;
+  public Set<Map.Entry<Long, Set<CACHEKEY>>> getEpochEntrySet() {

Review comment:
       > `TestTableCache` unit test checks the size of this set. Now the result size is equal to epoch count, previously it was cache entry count. The test is still passing, because it never uses the same epoch in a single test case.
   > 
   > Can you please add a test case for rename (where two entries have the same epoch) in `TestTableCache`?
   
   @adoroszlai  I have added the UT. PTAL.




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For additional commands, e-mail: issues-help@ozone.apache.org