[GitHub] [nifi] nandorsoma commented on a diff in pull request #6792: NIFI-10884 Conflict resolution in PutAzureDataLakeStorage should log the target filename

[GitBox <gi...@apache.org>]

nandorsoma commented on code in PR #6792:
URL: https://github.com/apache/nifi/pull/6792#discussion_r1051498998


##########
nifi-nar-bundles/nifi-azure-bundle/nifi-azure-processors/src/main/java/org/apache/nifi/processors/azure/storage/PutAzureDataLakeStorage.java:
##########
@@ -212,25 +212,38 @@ static void uploadContent(DataLakeFileClient fileClient, InputStream in, long le
         fileClient.flush(length, true);
     }
 
-    //Visible for testing
+    /**
+     * This method serves as a "commit" for the upload process. To support various Conflict Resolution Strategies the processor uploads
+     * the content of the FlowFile to a temporary file with a unique name, then attempts to rename it. It is not an efficient approach,
+     * especially for large files, but it is needed because of the issue (azure-sdk-for-java/issues/31248) linked above.

Review Comment:
   Hey @turcsanyip!
   Thanks for the review. It seems like I misinterpreted one of the comments in the linked issue. Fixed the doc!



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@nifi.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org