You are viewing a plain text version of this content. The canonical link for it is here.

Posted to gitbox@activemq.apache.org by GitBox <gi...@apache.org> on 2021/02/23 13:23:29 UTC

[GitHub] [activemq-artemis] franz1981 commented on a change in pull request #3462: ARTEMIS-3133 Reduce memory usage for Null an Ping packets

franz1981 commented on a change in pull request #3462:
URL: https://github.com/apache/activemq-artemis/pull/3462#discussion_r581029960



##########
File path: artemis-server/src/main/java/org/apache/activemq/artemis/core/protocol/core/ServerSessionPacketHandler.java
##########
@@ -921,7 +979,11 @@ private void doConfirmAndResponse(final Packet confirmPacket,
       }
 
       if (response != null) {
-         channel.send(response);
+         try {
+            channel.send(response);

Review comment:
       it's completely sync and won't retain the `Packet` unless the conf window size is != -1, where it can use a `resendCache` to retaining it.
   In this case the caching won't happen, see https://github.com/apache/activemq-artemis/pull/3462/files#diff-c58d25d4978ebff7d03f1e5858b8b3344b01b3f2376e5ff194483d85c7b36a09R200-R208




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org