You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@ranger.apache.org by Nikhil P <np...@gmail.com> on 2019/03/22 07:17:17 UTC

Re: Review Request 70254: RANGER-2373 : User creation POST and PUT response not showing groupIdList and groupNameList with expected data

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/70254/
-----------------------------------------------------------

(Updated March 22, 2019, 12:47 p.m.)


Review request for ranger, Gautam Borad, Abhay Kulkarni, Madhan Neethiraj, Pradeep Agrawal, Ramesh Mani, Selvamohan Neethiraj, Sailaja Polavarapu, and Velmurugan Periasamy.


Changes
-------

resolved review comments


Summary (updated)
-----------------

RANGER-2373 : User creation POST and PUT response not showing groupIdList and groupNameList with expected data


Bugs: RANGER-2373
    https://issues.apache.org/jira/browse/RANGER-2373


Repository: ranger


Description
-------

User creation POST and PUT response should show groupIdList and groupNameList


Diffs (updated)
-----

  security-admin/src/main/java/org/apache/ranger/biz/XUserMgr.java fc40917 
  security-admin/src/test/java/org/apache/ranger/biz/TestXUserMgr.java 49c57a6 


Diff: https://reviews.apache.org/r/70254/diff/2/

Changes: https://reviews.apache.org/r/70254/diff/1-2/


Testing
-------

validated If user creation and updation response is showing expected list of group Id / group Name.

1.Tested CRUD for users.
2.Tested CRUD for groups.
3.Checked adding users to group.
4.Checked users are getting deleted when groups are assigned to it.


File Attachments (updated)
----------------

RANGER-2373-2.patch
  https://reviews.apache.org/media/uploaded/files/2019/03/22/f1f0b2d5-68d1-4413-b5f7-f8836b2dc2a8__RANGER-2373-2.patch


Thanks,

Nikhil P


Re: Review Request 70254: RANGER-2373 : User creation POST and PUT response not showing groupIdList and groupNameList with expected data

Posted by Zsombor Gegesy <zs...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/70254/#review213910
-----------------------------------------------------------


Ship it!




Ship It!

- Zsombor Gegesy


On March 22, 2019, 7:17 a.m., Nikhil P wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/70254/
> -----------------------------------------------------------
> 
> (Updated March 22, 2019, 7:17 a.m.)
> 
> 
> Review request for ranger, Gautam Borad, Abhay Kulkarni, Madhan Neethiraj, Pradeep Agrawal, Ramesh Mani, Selvamohan Neethiraj, Sailaja Polavarapu, and Velmurugan Periasamy.
> 
> 
> Bugs: RANGER-2373
>     https://issues.apache.org/jira/browse/RANGER-2373
> 
> 
> Repository: ranger
> 
> 
> Description
> -------
> 
> User creation POST and PUT response should show groupIdList and groupNameList
> 
> 
> Diffs
> -----
> 
>   security-admin/src/main/java/org/apache/ranger/biz/XUserMgr.java fc40917 
>   security-admin/src/test/java/org/apache/ranger/biz/TestXUserMgr.java 49c57a6 
> 
> 
> Diff: https://reviews.apache.org/r/70254/diff/2/
> 
> 
> Testing
> -------
> 
> validated If user creation and updation response is showing expected list of group Id / group Name.
> 
> 1.Tested CRUD for users.
> 2.Tested CRUD for groups.
> 3.Checked adding users to group.
> 4.Checked users are getting deleted when groups are assigned to it.
> 
> 
> File Attachments
> ----------------
> 
> RANGER-2373-2.patch
>   https://reviews.apache.org/media/uploaded/files/2019/03/22/f1f0b2d5-68d1-4413-b5f7-f8836b2dc2a8__RANGER-2373-2.patch
> 
> 
> Thanks,
> 
> Nikhil P
> 
>