You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@pinot.apache.org by GitBox <gi...@apache.org> on 2021/02/23 00:06:21 UTC
[GitHub] [incubator-pinot] jihaozh opened a new pull request #6601: [TE] Conform to standard SQL requirement for quotes
jihaozh opened a new pull request #6601:
URL: https://github.com/apache/incubator-pinot/pull/6601
Conform to standard SQL requirement for quotes as Pinot moves to standard SQL.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org
For additional commands, e-mail: commits-help@pinot.apache.org
[GitHub] [incubator-pinot] jihaozh merged pull request #6601: [TE] Conform to standard SQL requirement for quotes
Posted by GitBox <gi...@apache.org>.
jihaozh merged pull request #6601:
URL: https://github.com/apache/incubator-pinot/pull/6601
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org
For additional commands, e-mail: commits-help@pinot.apache.org
[GitHub] [incubator-pinot] jihaozh commented on pull request #6601: [TE] Conform to standard SQL requirement for quotes
Posted by GitBox <gi...@apache.org>.
jihaozh commented on pull request #6601:
URL: https://github.com/apache/incubator-pinot/pull/6601#issuecomment-783799260
> @jihaozh , IIUC, this is related to the invalid query compilation issues at Li. There were 2 things that need to be done to fix the queries
>
> * Escape reserved keywords with double quotes
> * Use string filter literals in single quotes.
>
> I don't think this PR takes care of both. Also, to make sure everything has been covered, I hope the internal wiki for correct SQL syntax I pointed to was followed?
As discussed offline, another PR should already take care of it. Thanks.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org
For additional commands, e-mail: commits-help@pinot.apache.org
[GitHub] [incubator-pinot] siddharthteotia commented on pull request #6601: [TE] Conform to standard SQL requirement for quotes
Posted by GitBox <gi...@apache.org>.
siddharthteotia commented on pull request #6601:
URL: https://github.com/apache/incubator-pinot/pull/6601#issuecomment-783789122
@jihaozh , IIUC, this is related to the invalid query compilation issues at Li. There were 2 things that need to be done to fix the queries
- Escape reserved keywords with double quotes
- Use string filter literals in single quotes.
I don't think this PR takes care of both. Also, to make sure everything has been covered, I hope the internal wiki for correct SQL syntax I pointed to was followed?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org
For additional commands, e-mail: commits-help@pinot.apache.org