You are viewing a plain text version of this content. The canonical link for it is here.

Posted to issues@calcite.apache.org by "Xiening Dai (Jira)" <ji...@apache.org> on 2020/04/15 18:40:00 UTC

[jira] [Commented] (CALCITE-3927) RelSubset is not fired for rule when set gets merged

    [ https://issues.apache.org/jira/browse/CALCITE-3927?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17084302#comment-17084302 ] 

Xiening Dai commented on CALCITE-3927:
--------------------------------------

Can we come up with a test case? Just try to assess the impact of this in real world scenarios.

> RelSubset is not fired for rule when set gets merged
> ----------------------------------------------------
>
>                 Key: CALCITE-3927
>                 URL: https://issues.apache.org/jira/browse/CALCITE-3927
>             Project: Calcite
>          Issue Type: Bug
>          Components: core
>            Reporter: Haisheng Yuan
>            Priority: Major
>
> In VolcanoPlanner, when set gets merged, planner fires rules again for RelNodes in both sets, but not for RelSubset. We might miss something because of this. 
> If all the logical transformation rules and physical implementation rules are separated out in different stage and physical rules don't do logical work, we might be OK. But the reality is that all the things are mixed together at the moment.



--
This message was sent by Atlassian Jira
(v8.3.4#803005)