You are viewing a plain text version of this content. The canonical link for it is here.
Posted to github@arrow.apache.org by "comphead (via GitHub)" <gi...@apache.org> on 2023/03/09 03:10:28 UTC
[GitHub] [arrow-rs] comphead opened a new pull request, #3822: Minor: Fix error message for CSV formatting
comphead opened a new pull request, #3822:
URL: https://github.com/apache/arrow-rs/pull/3822
# Which issue does this PR close?
<!--
We generally require a GitHub issue to be filed for all bug fixes and enhancements and this helps us generate change logs for our releases. You can link an issue to this PR using the GitHub syntax. For example `Closes #123` indicates that this PR will close issue #123.
-->
Closes #.
# Rationale for this change
Faced when retesting https://github.com/apache/arrow-datafusion/issues/4947
Current error message a bit misleading
<!--
Why are you proposing this change? If this is already explained clearly in the issue then this section is not needed.
Explaining clearly why changes are proposed helps reviewers understand your changes and offer better suggestions for fixes.
-->
# What changes are included in this PR?
<!--
There is no need to duplicate the description in the issue here but it is sometimes worth providing a summary of the individual changes in this PR.
-->
# Are there any user-facing changes?
No
<!--
If there are user-facing changes then we may require documentation to be updated before approving the PR.
-->
<!---
If there are any breaking changes to public APIs, please add the `breaking change` label.
-->
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow-rs] ursabot commented on pull request #3822: Minor: Fix error message for CSV formatting
Posted by "ursabot (via GitHub)" <gi...@apache.org>.
ursabot commented on PR #3822:
URL: https://github.com/apache/arrow-rs/pull/3822#issuecomment-1462028055
Benchmark runs are scheduled for baseline = 053973a06a7194a1d10f5b206375957a2fcaa049 and contender = fb1dcc6d792bc390b0eeea867ca76f3d2c1d8334. fb1dcc6d792bc390b0eeea867ca76f3d2c1d8334 is a master commit associated with this PR. Results will be available as each benchmark for each run completes.
Conbench compare runs links:
[Skipped :warning: Benchmarking of arrow-rs-commits is not supported on ec2-t3-xlarge-us-east-2] [ec2-t3-xlarge-us-east-2](https://conbench.ursa.dev/compare/runs/4bd13764331141c9b2abc264065805d8...1ef12b64a8094a13ac022e94786e78b8/)
[Skipped :warning: Benchmarking of arrow-rs-commits is not supported on test-mac-arm] [test-mac-arm](https://conbench.ursa.dev/compare/runs/0f1f134ed37840a6b3935e5342f2e34d...9e48c3fb49f641e7afbe50ac156c3d70/)
[Skipped :warning: Benchmarking of arrow-rs-commits is not supported on ursa-i9-9960x] [ursa-i9-9960x](https://conbench.ursa.dev/compare/runs/a7f3fee7cc854a0db48fd7e8b5544e9d...f6e7297bd7104f6f8f1b0818a594ff4d/)
[Skipped :warning: Benchmarking of arrow-rs-commits is not supported on ursa-thinkcentre-m75q] [ursa-thinkcentre-m75q](https://conbench.ursa.dev/compare/runs/e5de65ecb40b4df18707095b35957233...f7bcfed7e249479e8dd6e8a7298ce40f/)
Buildkite builds:
Supported benchmarks:
ec2-t3-xlarge-us-east-2: Supported benchmark langs: Python, R. Runs only benchmarks with cloud = True
test-mac-arm: Supported benchmark langs: C++, Python, R
ursa-i9-9960x: Supported benchmark langs: Python, R, JavaScript
ursa-thinkcentre-m75q: Supported benchmark langs: C++, Java
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow-rs] tustvold merged pull request #3822: Minor: Fix error message for CSV formatting
Posted by "tustvold (via GitHub)" <gi...@apache.org>.
tustvold merged PR #3822:
URL: https://github.com/apache/arrow-rs/pull/3822
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow-rs] viirya commented on a diff in pull request #3822: Minor: Fix error message for CSV formatting
Posted by "viirya (via GitHub)" <gi...@apache.org>.
viirya commented on code in PR #3822:
URL: https://github.com/apache/arrow-rs/pull/3822#discussion_r1130378843
##########
arrow-csv/src/writer.rs:
##########
@@ -169,7 +169,7 @@ impl<W: Write> Writer<W> {
buffer.clear();
converter.value(row_idx).write(&mut buffer).map_err(|e| {
ArrowError::CsvError(format!(
- "Error formatting row {} and column {}: {e}",
+ "Error processing row {}, col {}: {e}",
Review Comment:
I think it is `formatting` because the error comes from `ArrayFormater`. `processing` is okay though. The change of row and col looks okay too.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org