You are viewing a plain text version of this content. The canonical link for it is here.

Posted to commits@cloudstack.apache.org by GitBox <gi...@apache.org> on 2021/07/13 07:03:03 UTC

[GitHub] [cloudstack] sureshanaparti commented on pull request #4790: Externalize secondary storage capacity threshold

sureshanaparti commented on pull request #4790:
URL: https://github.com/apache/cloudstack/pull/4790#issuecomment-878832667


   > @sureshanaparti Thank you for the review.
   > 
   > As you suggested, I added the config to the validation in `ConfigurationManagerImpl`. However, I had to change the config type from `Double` to `Float` (not that it is a problem) because the validation only works on `Float` configs.
   > I tested some of they and realize that those with `Double` type are not validated. I think we need some refactors in this validation, in another PR. What do you think?
   
   @GutoVeronezi agree, these validations can be refactored in another PR.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org