[GitHub] [apisix] Yiyiyimu commented on a change in pull request #4484: chore: update tinyyaml lib and remove unnecessary quotes in config

[GitBox <gi...@apache.org>]

Yiyiyimu commented on a change in pull request #4484:
URL: https://github.com/apache/apisix/pull/4484#discussion_r660258088



##########
File path: conf/config-default.yaml
##########
@@ -52,8 +52,8 @@ apisix:
                                    # which cache to use by name in the admin api
         memory_size: 50m           # The size of shared memory, it's used to store the cache index
         disk_size: 1G              # The size of disk, it's used to store the cache data
-        disk_path: "/tmp/disk_cache_one"  # The path to store the cache data

Review comment:
       Tested in yaml repo: https://github.com/Yiyiyimu/lua-tinyyaml/blob/test/symbols/spec/map_spec.lua#L57-L64 Do we need tests also in this repo?
   
   BTW, I fix the bug causing the CI failure in that PR but I'm not sure if there are any other bugs. Is there any method to run CI with un-released lua rocks? Or should I create a temporary rock for the test, and if everything goes correctly, then we make the new release?




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@apisix.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org