[GitHub] [groovy] eric-milles commented on a change in pull request #938: Update tests for GROOVY-9043, GROOVY-9093, GROOVY-9106, et al.

[GitBox <gi...@apache.org>]

eric-milles commented on a change in pull request #938: Update tests for GROOVY-9043, GROOVY-9093, GROOVY-9106, et al.
URL: https://github.com/apache/groovy/pull/938#discussion_r288278365
 
 

 ##########
 File path: src/test/org/codehaus/groovy/transform/packageScope/PackageScopeTransformTest.groovy
 ##########
 @@ -18,20 +18,22 @@
  */
 package org.codehaus.groovy.transform.packageScope
 
+import groovy.transform.CompileStatic
+
 import java.lang.reflect.Modifier
 
-class PackageScopeTransformTest extends GroovyShellTestCase {
+@CompileStatic
+final class PackageScopeTransformTest extends GroovyShellTestCase {
     // GROOVY-9043
-    void testPackagePrivateAccessFromInnerClassCS() {
-        assertScript '''
+    void testStaticFieldAccessFromInnerClassCS() {
+        assertScript('''\
 
 Review comment:
   I'm fine with that style for scripts and printlns.  But I find it much more natural to have the parens for method calls within classes.  I've seen the parens added back as soon as there is just one more param to pass, even though that form could have been written without parens.
   
   The backslash is to escape the first newline; it is most useful if using `stripIndent()` on the string literal.  I would have provided that as well, but it was stripped off in a recent commit.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services