You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@cxf.apache.org by se...@apache.org on 2016/01/19 12:40:36 UTC
cxf git commit: Fixing a typo in the code grant handler
Repository: cxf
Updated Branches:
refs/heads/master a9bd49ff0 -> f11ec01ac
Fixing a typo in the code grant handler
Project: http://git-wip-us.apache.org/repos/asf/cxf/repo
Commit: http://git-wip-us.apache.org/repos/asf/cxf/commit/f11ec01a
Tree: http://git-wip-us.apache.org/repos/asf/cxf/tree/f11ec01a
Diff: http://git-wip-us.apache.org/repos/asf/cxf/diff/f11ec01a
Branch: refs/heads/master
Commit: f11ec01ac603a7b3919ed075afc9ac35edf48c8a
Parents: a9bd49f
Author: Sergey Beryozkin <sb...@gmail.com>
Authored: Tue Jan 19 11:40:19 2016 +0000
Committer: Sergey Beryozkin <sb...@gmail.com>
Committed: Tue Jan 19 11:40:19 2016 +0000
----------------------------------------------------------------------
.../oauth2/grants/code/AuthorizationCodeGrantHandler.java | 6 +++---
1 file changed, 3 insertions(+), 3 deletions(-)
----------------------------------------------------------------------
http://git-wip-us.apache.org/repos/asf/cxf/blob/f11ec01a/rt/rs/security/oauth-parent/oauth2/src/main/java/org/apache/cxf/rs/security/oauth2/grants/code/AuthorizationCodeGrantHandler.java
----------------------------------------------------------------------
diff --git a/rt/rs/security/oauth-parent/oauth2/src/main/java/org/apache/cxf/rs/security/oauth2/grants/code/AuthorizationCodeGrantHandler.java b/rt/rs/security/oauth-parent/oauth2/src/main/java/org/apache/cxf/rs/security/oauth2/grants/code/AuthorizationCodeGrantHandler.java
index 6d7fc1a..7e5aab3 100644
--- a/rt/rs/security/oauth-parent/oauth2/src/main/java/org/apache/cxf/rs/security/oauth2/grants/code/AuthorizationCodeGrantHandler.java
+++ b/rt/rs/security/oauth-parent/oauth2/src/main/java/org/apache/cxf/rs/security/oauth2/grants/code/AuthorizationCodeGrantHandler.java
@@ -113,11 +113,11 @@ public class AuthorizationCodeGrantHandler extends AbstractGrantHandler {
private boolean compareCodeVerifierWithChallenge(Client c, String clientCodeVerifier,
String clientCodeChallenge) {
- if (clientCodeChallenge == null && clientCodeChallenge == null
+ if (clientCodeChallenge == null && clientCodeVerifier == null
&& (c.isConfidential() || !expectCodeVerifierForPublicClients)) {
return true;
- } else if (clientCodeChallenge != null && clientCodeChallenge == null
- || clientCodeChallenge == null && clientCodeChallenge != null) {
+ } else if (clientCodeChallenge != null && clientCodeVerifier == null
+ || clientCodeChallenge == null && clientCodeVerifier != null) {
return false;
} else {
String transformedCodeVerifier = codeVerifierTransformer == null