You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@mesos.apache.org by Jojy Varghese <jo...@mesosphere.io> on 2016/02/11 02:16:51 UTC
Review Request 43466: Added const qualifier for uri::Fetcher::fetch.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/43466/
-----------------------------------------------------------
Review request for mesos and Jie Yu.
Repository: mesos
Description
-------
Added const qualifier for uri::Fetcher::fetch.
Diffs
-----
include/mesos/uri/fetcher.hpp baa32d3a1157308af33ea06a7a65e2751d970115
src/uri/fetcher.cpp dfda732348fec3b686cf82b55ad94fda4829469b
Diff: https://reviews.apache.org/r/43466/diff/
Testing
-------
make check.
Thanks,
Jojy Varghese
Re: Review Request 43466: Added const qualifier for
uri::Fetcher::fetch.
Posted by Mesos ReviewBot <re...@mesos.apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/43466/#review118816
-----------------------------------------------------------
Bad patch!
Reviews applied: [41958, 41959, 42156, 42157, 43127, 43198]
Failed command: ./support/apply-review.sh -n -r 43198
Error:
2016-02-11 06:12:36 URL:https://reviews.apache.org/r/43198/diff/raw/ [4884/4884] -> "43198.patch" [1]
src/appc/spec.cpp:146: Redundant blank line at the end of a code block should be deleted. [whitespace/blank_line] [3]
Total errors found: 1
Checking 2 files
Full log: https://builds.apache.org/job/mesos-reviewbot/11379/console
- Mesos ReviewBot
On Feb. 11, 2016, 1:16 a.m., Jojy Varghese wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/43466/
> -----------------------------------------------------------
>
> (Updated Feb. 11, 2016, 1:16 a.m.)
>
>
> Review request for mesos and Jie Yu.
>
>
> Repository: mesos
>
>
> Description
> -------
>
> Added const qualifier for uri::Fetcher::fetch.
>
>
> Diffs
> -----
>
> include/mesos/uri/fetcher.hpp baa32d3a1157308af33ea06a7a65e2751d970115
> src/uri/fetcher.cpp dfda732348fec3b686cf82b55ad94fda4829469b
>
> Diff: https://reviews.apache.org/r/43466/diff/
>
>
> Testing
> -------
>
> make check.
>
>
> Thanks,
>
> Jojy Varghese
>
>
Re: Review Request 43466: Added const qualifier for
uri::Fetcher::fetch.
Posted by Jie Yu <yu...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/43466/#review118910
-----------------------------------------------------------
Ship it!
Ship It!
- Jie Yu
On Feb. 11, 2016, 1:16 a.m., Jojy Varghese wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/43466/
> -----------------------------------------------------------
>
> (Updated Feb. 11, 2016, 1:16 a.m.)
>
>
> Review request for mesos and Jie Yu.
>
>
> Repository: mesos
>
>
> Description
> -------
>
> Added const qualifier for uri::Fetcher::fetch.
>
>
> Diffs
> -----
>
> include/mesos/uri/fetcher.hpp baa32d3a1157308af33ea06a7a65e2751d970115
> src/uri/fetcher.cpp dfda732348fec3b686cf82b55ad94fda4829469b
>
> Diff: https://reviews.apache.org/r/43466/diff/
>
>
> Testing
> -------
>
> make check.
>
>
> Thanks,
>
> Jojy Varghese
>
>