You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@superset.apache.org by GitBox <gi...@apache.org> on 2019/01/10 03:24:28 UTC
[GitHub] kristw commented on a change in pull request #6617: #6588 Clear all
other query tabs
kristw commented on a change in pull request #6617: #6588 Clear all other query tabs
URL: https://github.com/apache/incubator-superset/pull/6617#discussion_r246626222
##########
File path: superset/assets/src/SqlLab/components/TabbedSqlEditors.jsx
##########
@@ -152,6 +156,10 @@ class TabbedSqlEditors extends React.PureComponent {
removeQueryEditor(qe) {
this.props.actions.removeQueryEditor(qe);
}
+ removeAllOtherQueryEditors(cqe) {
+ this.props.queryEditors
+ .map(qe => qe !== cqe && this.removeQueryEditor(qe));
Review comment:
nit. `.forEach` is probably more appropriate than `.map` here.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org