You are viewing a plain text version of this content. The canonical link for it is here.
Posted to gitbox@activemq.apache.org by GitBox <gi...@apache.org> on 2021/05/21 16:34:07 UTC

[GitHub] [activemq] maxfortun opened a new pull request #655: Allow url parameters to specify initial sort order

maxfortun opened a new pull request #655:
URL: https://github.com/apache/activemq/pull/655


   This change will allow to pass `sortColumnId` and `sortOrder` url parameters to console's queues view, thus ordering the data on-load. This is very useful when visually monitoring dequeued messages change over time.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [activemq] mattrpav commented on pull request #655: [AMQ-8274] Allow url parameters to specify initial sort order

Posted by GitBox <gi...@apache.org>.
mattrpav commented on pull request #655:
URL: https://github.com/apache/activemq/pull/655#issuecomment-966458323


   @maxfortun The tests probably failing due to previous Jenkins build rules. If you rebase the PR, it should be able to go green.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: gitbox-unsubscribe@activemq.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [activemq] maxfortun commented on pull request #655: [AMQ-8274] Allow url parameters to specify initial sort order

Posted by GitBox <gi...@apache.org>.
maxfortun commented on pull request #655:
URL: https://github.com/apache/activemq/pull/655#issuecomment-966424406


   I am not sure why maven tests are failing. My changes were only to a front end javascript file. Is this a blocker for a merge?


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: gitbox-unsubscribe@activemq.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [activemq] mattrpav commented on pull request #655: [AMQ-8274] Allow url parameters to specify initial sort order

Posted by GitBox <gi...@apache.org>.
mattrpav commented on pull request #655:
URL: https://github.com/apache/activemq/pull/655#issuecomment-1016532008


   I’m working on tasks to get into 5.16.4. This is one. Should be within the next week. Thanks!


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: gitbox-unsubscribe@activemq.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [activemq] maxfortun commented on pull request #655: [AMQ-8274] Allow url parameters to specify initial sort order

Posted by GitBox <gi...@apache.org>.
maxfortun commented on pull request #655:
URL: https://github.com/apache/activemq/pull/655#issuecomment-846099687


   https://issues.apache.org/jira/browse/AMQ-8274


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [activemq] maxfortun commented on pull request #655: [AMQ-8274] Allow url parameters to specify initial sort order

Posted by GitBox <gi...@apache.org>.
maxfortun commented on pull request #655:
URL: https://github.com/apache/activemq/pull/655#issuecomment-1016492262


   How do I get this PR merged in?


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: gitbox-unsubscribe@activemq.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [activemq] maxfortun removed a comment on pull request #655: [AMQ-8274] Allow url parameters to specify initial sort order

Posted by GitBox <gi...@apache.org>.
maxfortun removed a comment on pull request #655:
URL: https://github.com/apache/activemq/pull/655#issuecomment-846099687


   https://issues.apache.org/jira/browse/AMQ-8274


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [activemq] mattrpav commented on pull request #655: Allow url parameters to specify initial sort order

Posted by GitBox <gi...@apache.org>.
mattrpav commented on pull request #655:
URL: https://github.com/apache/activemq/pull/655#issuecomment-846094142


   Hello @maxfortun, thanks for the PR. Will review. Do you happen to have a JIRA to reference for this? 
   
   If not, it is quick to open one at [Apache JIRA](https://issues.apache.org/jira) -- select 'ActiveMQ' as the project and 'Web Console' as the component. Release notes are generated from the JIRAs, so features and fixes like this can be communicated to users.
   
   Thanks!
   
    


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [activemq] maxfortun commented on pull request #655: Allow url parameters to specify initial sort order

Posted by GitBox <gi...@apache.org>.
maxfortun commented on pull request #655:
URL: https://github.com/apache/activemq/pull/655#issuecomment-846098737


   Thank you, just created the issue:
   
   https://issues.apache.org/jira/browse/AMQ-8274
   
   > On May 21, 2021, at 12:42 PM, Matt Pavlovich ***@***.***> wrote:
   > 
   > 
   > Hello @maxfortun <https://github.com/maxfortun>, thanks for the PR. Will review. Do you happen to have a JIRA to reference for this?
   > 
   > If not, it is quick to open one at Apache JIRA <https://issues.apache.org/jira> -- select 'ActiveMQ' as the project and 'Web Console' as the component. Release notes are generated from the JIRAs, so features and fixes like this can be communicated to users.
   > 
   > Thanks!
   > 
   > —
   > You are receiving this because you were mentioned.
   > Reply to this email directly, view it on GitHub <https://github.com/apache/activemq/pull/655#issuecomment-846094142>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/ACNVZ5GTQFNF566I4ND2AODTO2EN3ANCNFSM45JPH4IQ>.
   > 
   
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org