[jira] [Commented] (SOLR-13389) rectify discrepencies in socket (and connect) timeout values used throughout the code and tests - probably helping to reduce TimeoutExceptions in tests

["Gus Heck (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/SOLR-13389?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16834244#comment-16834244 ] 

Gus Heck commented on SOLR-13389:
---------------------------------

I see two issues here:
 # How do we bring sanity to the management of timeout settings in the application
 # What those settings should look like when running the tests

Do we want to deal with both issues here, or maybe separate them? 

> rectify discrepencies in socket (and connect) timeout values used throughout the code and tests - probably helping to reduce TimeoutExceptions in tests
> -------------------------------------------------------------------------------------------------------------------------------------------------------
>
>                 Key: SOLR-13389
>                 URL: https://issues.apache.org/jira/browse/SOLR-13389
>             Project: Solr
>          Issue Type: Task
>      Security Level: Public(Default Security Level. Issues are Public) 
>            Reporter: Hoss Man
>            Assignee: Hoss Man
>            Priority: Major
>
> While looking into some jenkins test failures caused by distributed requests that timeout, i realized that the "socket timeout" aka "idle timeout" aka "SO_TIMEOUT" values used in various places in the code & sample configs can vary significantly, and in the case of *test* configs/code can differ from the default / production configs by an order of magnitude.
> I think we should consider rectifying some of the various places/ways that different values are sprinkled through out the code to reduce the number of (different) places we have magic constants.  I believe a large number of jenkins test failures we currently see due to timeout exceptions are simply because tests (or test configs) override sensible defaults w/values that are too low to be useful.
> (NOTE: all of these problems / discrepancies also apply to "connect timeout" which should probably be addressed at the same time, but for now i'm focusing on the "socket timeout" since it seems to be the bigger problem in jenkins failures -- if we reach consensus on standardizing some values across the board the same approach can be made to connect timeouts at the same time)



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@lucene.apache.org
For additional commands, e-mail: dev-help@lucene.apache.org