You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@skywalking.apache.org by GitBox <gi...@apache.org> on 2021/11/07 10:21:34 UTC
[GitHub] [skywalking-infra-e2e] mrproliu commented on a change in pull request #65: Add changes for 1.1.0 version
mrproliu commented on a change in pull request #65:
URL: https://github.com/apache/skywalking-infra-e2e/pull/65#discussion_r744234762
##########
File path: Makefile
##########
@@ -41,7 +41,7 @@ all: clean lint test build
.PHONY: lint
lint:
- $(GO_LINT) version || curl -sSfL https://raw.githubusercontent.com/golangci/golangci-lint/master/install.sh | sh -s -- -b $(GO_PATH)/bin
+ $(GO_LINT) version || curl -sSfL https://raw.githubusercontent.com/golangci/golangci-lint/v1.42.1/install.sh | sh -s -- -b $(GO_PATH)/bin
Review comment:
Please use `-d <tag>` to appoint the version. So changed to `$(GO_LINT) version || curl -sSfL https://raw.githubusercontent.com/golangci/golangci-lint/master/install.sh | sh -s -- -b $(GO_PATH)/bin -d "v1.42.1"`.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@skywalking.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org