You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@rocketmq.apache.org by "majialoong (via GitHub)" <gi...@apache.org> on 2026/08/12 15:56:19 UTC

[PR] [ISSUE #10912] Fix native memory leak in PopConsumerRocksdbStore [rocketmq]

majialoong opened a new pull request, #10913:
URL: https://github.com/apache/rocketmq/pull/10913

   <!-- Please make sure the target branch is right. In most case, the target branch should be `develop`. -->
   
   ### Which Issue(s) This PR Fixes
   
   
   - Fixes #10912 
   
   ### Brief Description
   
   Close the RocksDB Slice objects created in `scanExpiredRecords()` to prevent native memory leaks.
   
   ### How Did You Test This Change?
   
   Ran the existing PopConsumerRocksdbStoreTest and verified that native memory remains stable during repeated scans.
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@rocketmq.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] [ISSUE #10912] Fix native memory leak in PopConsumerRocksdbStore [rocketmq]

Posted by "codecov-commenter (via GitHub)" <gi...@apache.org>.
codecov-commenter commented on PR #10913:
URL: https://github.com/apache/rocketmq/pull/10913#issuecomment-5269496149

   ## [Codecov](https://app.codecov.io/gh/apache/rocketmq/pull/10913?dropdown=coverage&src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) Report
   :white_check_mark: All modified and coverable lines are covered by tests.
   :white_check_mark: Project coverage is 48.35%. Comparing base ([`97a7975`](https://app.codecov.io/gh/apache/rocketmq/commit/97a797543bad7697a79ea227671f3047266b6620?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)) to head ([`b2f2cd7`](https://app.codecov.io/gh/apache/rocketmq/commit/b2f2cd73e5ad011085142bbe8143995e9536f342?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)).
   
   <details><summary>Additional details and impacted files</summary>
   
   
   
   ```diff
   @@              Coverage Diff              @@
   ##             develop   #10913      +/-   ##
   =============================================
   - Coverage      48.46%   48.35%   -0.12%     
   + Complexity     13584    13553      -31     
   =============================================
     Files           1380     1380              
     Lines         101195   101197       +2     
     Branches       13130    13130              
   =============================================
   - Hits           49040    48929     -111     
   - Misses         46188    46279      +91     
   - Partials        5967     5989      +22     
   ```
   </details>
   
   [:umbrella: View full report in Codecov by Harness](https://app.codecov.io/gh/apache/rocketmq/pull/10913?dropdown=coverage&src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache).   
   :loudspeaker: Have feedback on the report? [Share it here](https://about.codecov.io/codecov-pr-comment-feedback/?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache).
   <details><summary> :rocket: New features to boost your workflow: </summary>
   
   - :snowflake: [Test Analytics](https://docs.codecov.com/docs/test-analytics): Detect flaky tests, report on failures, and find test suite problems.
   </details>


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@rocketmq.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org