You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@couchdb.apache.org by GitBox <gi...@apache.org> on 2022/06/18 10:15:11 UTC
[GitHub] [couchdb-helm] colearendt opened a new pull request, #87: Fix ci permissions
colearendt opened a new pull request, #87:
URL: https://github.com/apache/couchdb-helm/pull/87
#### What this PR does / why we need it:
The Apache Foundation has [guidance](https://cwiki.apache.org/confluence/display/BUILDS/GitHub+Actions+status) that was missed on my first PR for GitHub Actions usage. This PR addresses that feedback.
#### Which issue this PR fixes
*(optional, in `fixes #<issue number>(, fixes #<issue_number>, ...)` format, will close that issue when PR gets merged)*
- fixes #62
#### Special notes for your reviewer:
Comments made in #62 ()
#### Checklist
[Place an '[x]' (no spaces) in all applicable fields. Please remove unrelated fields.
- [ ] Chart Version bumped
- [ ] e2e tests pass
- [ ] Variables are documented in the README.md
- [ ] Chart tgz added to /docs and index updated
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@couchdb.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [couchdb-helm] willholley merged pull request #87: Fix ci permissions
Posted by GitBox <gi...@apache.org>.
willholley merged PR #87:
URL: https://github.com/apache/couchdb-helm/pull/87
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@couchdb.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [couchdb-helm] colearendt commented on pull request #87: Fix ci permissions
Posted by GitBox <gi...@apache.org>.
colearendt commented on PR #87:
URL: https://github.com/apache/couchdb-helm/pull/87#issuecomment-1159444730
It looks like CI is happy... although I'll defer to you if you think there is anything we should improve about the logs here before we move on: https://github.com/apache/couchdb-helm/runs/6947632474?check_suite_focus=true
It seems like it succeeded... but I suspect there are some things that can be done long term to improve / ensure that we are picking up health of the service / etc. Maybe those are best as follow-ups?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@couchdb.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [couchdb-helm] colearendt commented on pull request #87: Fix ci permissions
Posted by GitBox <gi...@apache.org>.
colearendt commented on PR #87:
URL: https://github.com/apache/couchdb-helm/pull/87#issuecomment-1160191752
@willholley `helm test` is covered by the `ct install --upgrade` step. The trick is that the couchdb helm chart doesn't have any "test hooks" included in it. As a result, `helm test` does nothing. By writing test jobs / hooks, we can run couchdb specific checks (in Kubernetes jobs) to be sure that the service is up / happy / has a user provisioned, etc.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@couchdb.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [couchdb-helm] colearendt commented on pull request #87: Fix ci permissions
Posted by GitBox <gi...@apache.org>.
colearendt commented on PR #87:
URL: https://github.com/apache/couchdb-helm/pull/87#issuecomment-1159440596
A note about the way that CI is currently set up:
- on this PR, there are no chart changes
- as a result, the chart "CI" does not run
Would it be preferable to set it up so that if there are changes to the `.github/workflows` directory, the "all" lint/installs run? (Not sure how hard/tedious this is to detect off-hand...). An alternative way to test more thoroughly would be to create a dummy PR with a chart change (or add a commit that changes the chart and then remove it / revert it)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@couchdb.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [couchdb-helm] willholley commented on pull request #87: Fix ci permissions
Posted by GitBox <gi...@apache.org>.
willholley commented on PR #87:
URL: https://github.com/apache/couchdb-helm/pull/87#issuecomment-1160123887
> or only trigger the CI if changes are in the chart directory / the .github/workflows or .github/actions folder (i.e. remove the "change detection" since you just have a single chart). This latter approach seems like a cleaner solution to me.
Agree this sounds cleaner. +1
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@couchdb.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [couchdb-helm] willholley commented on pull request #87: Fix ci permissions
Posted by GitBox <gi...@apache.org>.
willholley commented on PR #87:
URL: https://github.com/apache/couchdb-helm/pull/87#issuecomment-1160127882
Thanks for this follow up @colearendt. On `helm test`, is this not covered by the `ct install --upgrade` step?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@couchdb.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org